Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️Correct typo of required in comment in .pre-commit-config.yml #465

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

jsnel
Copy link
Contributor

@jsnel jsnel commented Dec 27, 2022

See also #453 which corrected this typo in the files in the inst folder.

I noticed this typo in my config file after using precommit::use_precommit() to setup pre-commit for my R package, and then found out that this was mostly likely fixed by #453 but didn't make it to a new release yet (still using 0.3.2, and changes on main since then [here](v0.3.2...main indicate it was fixed since then) ). However, when searching for the string in question I found another instance of it in the precommit config file used by the project itself. I thought you might want to correct that as well, hence this PR. ^^

Additional note, when saving the file my editor removed a lot of trailing spaces automatically. I did not add that to this commit, but maybe something to look into it, since it's a common setting nowadays.

Version details

R version 4.2.2 (2022-10-31 ucrt)
Platform: x86_64-w64-mingw32/x64 (64-bit)

precommit::version_precommit()
[1] "2.20.0"
packageVersion("precommit")
[1] ‘0.3.2’

See also lorenzwalthert#453 which corrected this typo in the files in the inst folder.
@lorenzwalthert
Copy link
Owner

Great thanks. If you want, you can push the change also that removes the trailing spaces. It’s a bit surprising to me because there should be a hook to remove these spaces anyways…

also, pre-commit.CI seems broken for the tag in question.

@asottile
Copy link
Contributor

pre-commit.ci run

@lorenzwalthert
Copy link
Owner

pre-commit.ci run

Horray, didn't know that trick 🎓

@lorenzwalthert lorenzwalthert merged commit 035e166 into lorenzwalthert:main Dec 28, 2022
@lorenzwalthert
Copy link
Owner

Thanks to both.

@jsnel jsnel deleted the fix/typo_in_comment branch December 29, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants