Upload raw benchmark results as an artifact. #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The raw benchmark results weren't available anywhere. Exposing them as an artifact is convenient for investigation and to customize the rendering and visualization after the fact. The receive action was uploading the PR comment as an artifact twice, once named "pr" and once named "results". Only the former is used by the comment action. Given the redundancy I assume this must have been a mistake. The "results" artifact now contains the raw benchmarking numbers instead. I've also removed a spurious download-artifact step, which was downloading the same files that had just been uploaded, for no apparent reason.
|
Here is a test run using the PR: https://github.com/plietar/touchstone-test/actions/runs/9159004097/job/25178507557 |
|
@plietar thanks for the suggestion. I don't have time for {touchstone} anymore, {precommit} and {styler} are already enough for me. Maybe @assignUser has / can? Sorry. I am also happy to transfer the repo to you or to #93. Would that be of interest to you? It would be great if the package can be further improved and I see you are eager to contribute 👍. |
assignUser
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The raw benchmark results weren't available anywhere. Exposing them as an artifact is convenient for investigation and to customize the rendering and visualization after the fact.
The receive action was uploading the PR comment as an artifact twice, once named "pr" and once named "results". Only the former is used by the comment action. Given the redundancy I assume this must have been a mistake. The "results" artifact now contains the raw benchmarking numbers instead.
I've also removed a spurious download-artifact step, which was downloading the same files that had just been uploaded, for no apparent reason.