Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import ABC from collections.abc instead of collections for Python 3 compatibility #24

Closed
wants to merge 1 commit into from

Conversation

tirkarthi
Copy link

Fixes #23

@rapgro
Copy link

rapgro commented Apr 17, 2021

This patch seems to not work with Python 3.4 or prior, but 3.5 and afterwards, see checks failed in CI.

@tirkarthi
Copy link
Author

The errors seem unrelated to the PR changes. It seems pytest 5.x is pulled in for Python 3.4 too which is not supported : https://docs.pytest.org/en/6.2.x/py27-py34-deprecation.html . Either pytest 4.x series can be pinned to ensure pytest works on Python 3.4 or the typing module can be added as a dependency for python version 3.4 and below.

@lorien lorien closed this Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing ABC directly from collections module was removed in Python 3.9
3 participants