Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests.py should not return 0 on fail #248

Merged
merged 1 commit into from Oct 31, 2016
Merged

tests.py should not return 0 on fail #248

merged 1 commit into from Oct 31, 2016

Conversation

jpstroop
Copy link
Member

Possible fix for #247

@jpstroop
Copy link
Member Author

Yay, it failed!

@jpstroop
Copy link
Member Author

I'm going to merge...may as well advertise the truth.

@jpstroop jpstroop merged commit daa22ae into development Oct 31, 2016
@jpstroop jpstroop deleted the non_zero_exit branch October 31, 2016 15:10
jrhoads
jrhoads reviewed Oct 31, 2016
View reviewed changes
Copy link
Contributor

@jrhoads jrhoads left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We were heading to this solution as well.
Thanks for the quick fix.

Question: Should we keep the verbosity so high for the tests we send to travis? It seems a shame that we cannot view the error in the travis web view of the log.

@jpstroop jpstroop mentioned this pull request Oct 31, 2016
Closed
@jpstroop
Copy link
Member Author

Should we keep the verbosity so high for the tests we send to travis? It seems a shame that we cannot view the error in the travis web view of the log.

I'm happy to have to volume turned down.

@jpstroop
Copy link
Member Author

I think this may be why that test.sh script existed, now that I think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhoads jrhoads jrhoads left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpstroop @jrhoads