Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LORO-288] [LORO-289] Use override linked list to store the linear cache history within a register #114

Closed
zxch3n opened this issue Sep 25, 2023 · 1 comment
Closed

[LORO-288] [LORO-289] Use override linked list to store the linear cache history within a register #114

zxch3n opened this issue Sep 25, 2023 · 1 comment
Labels
linear Sync the issue to Linear performance

Comments

@zxch3n
Copy link
Member

zxch3n commented Sep 25, 2023 •
edited
Loading

In the current implementation, we must go through all the history to calculate map diff if we are going backward #106

It's slow and the cache takes lots of memory. It can be more efficient with a linked list.

LORO-289
@zxch3n zxch3n added performance linear Sync the issue to Linear labels Sep 25, 2023
@zxch3n zxch3n changed the title Use override linked list to store the linear cache history within a register [LORO-288] Use override linked list to store the linear cache history within a register Sep 25, 2023
@zxch3n zxch3n changed the title Use override linked list to store the linear cache history within a register [LORO-289] Use override linked list to store the linear cache history within a register Sep 25, 2023
@zxch3n zxch3n changed the title [LORO-289] Use override linked list to store the linear cache history within a register [LORO-288] [LORO-289] Use override linked list to store the linear cache history within a register Sep 25, 2023
@zxch3n
Copy link
Member Author

zxch3n commented Mar 26, 2024

This optimization is already done by using op group

@zxch3n zxch3n closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
linear Sync the issue to Linear performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zxch3n