-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Stable JSON representation for history #368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.lock # crates/fuzz/Cargo.toml # crates/fuzz/fuzz/Cargo.lock
eb6daf4
to
ed0c643
Compare
871c01e
to
3d107a0
Compare
Leeeon233
commented
May 24, 2024
526a09b
to
7a5465f
Compare
zxch3n
reviewed
May 31, 2024
zxch3n
reviewed
May 31, 2024
zxch3n
reviewed
May 31, 2024
Leeeon233
commented
May 31, 2024
zxch3n
reviewed
May 31, 2024
zxch3n
reviewed
May 31, 2024
zxch3n
reviewed
May 31, 2024
97256e7
to
295e13a
Compare
19dd98f
to
94f801c
Compare
94f801c
to
6e021a5
Compare
zxch3n
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a JSON-based encoding scheme, intended as a common format before the stable document encoding format. The JSON format is highly readable and can be potentially used for visualization in devtools in the future.
Details
It generally aligns with the internal data structures
Change
andOp
of Loro, wherePeerID
is stored in an additional array and is simplified by using indexes in the content.ID
/IdLp
/CounterID
are all expressed in string form, and simultaneously, thePeerID
is replaced.JsonUnknown
type that ensures forward and backward compatibility for multiple versions of encoding and is also compatible with the binary unknown part.The specification of JSON representation