Feat transaction #83
Merged
Feat transaction #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Zixuan Chen <me@zxch3n.com>
fix: op counter
fix: map lamport order
Leeeon233
force-pushed
the
feat-transaction
branch
from
11b4de5
to
5e5f68f
Compare
Leeeon233
force-pushed
the
feat-transaction
branch
from
5e5f68f
to
ce00729
Compare
Leeeon233
force-pushed
the
feat-transaction
branch
from
486c12c
to
625e333
Compare
zxch3n
reviewed
Mar 20, 2023
zxch3n
reviewed
Mar 20, 2023
zxch3n
approved these changes
Mar 20, 2023
zxch3n
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
A transaction is an important feature. It can support atomicity, operation merging / event aggregation, and even meet the needs of parallel transactions and isolation for CRDT databases in the future. We will implement all the features in multiple versions.
This PR implements the first version of the transaction, or simply understands it as an event aggregator. All operations inside a transaction will be applied immediately. The events will be cached and attempted to be merged, sending them only when the transaction is committed.
We plan to implement the following features in future versions:
Opsinside a transaction into oneChangeto provide proper semantics for redo/undoTODO
use rope to concatenate and split String#81 has been merged in this pr.