add some more tests

main_test.go

@@ -30,14 +30,14 @@ func TestMain(t *testing.T) {
 		},
 		{
 			name:          "SuccessfulRun",
-			args:          []string{"schema", "-input", "testdata/fail.yaml"},
-			expectedOut:   "",
+			args:          []string{"schema", "-input", "testdata/basic.yaml"},
+			expectedOut:   "JSON schema successfully generated",
 			expectedError: "",
 		},
 		{
 			name:          "GenerateError",
 			args:          []string{"schema", "-input", "fail.yaml", "-draft", "2020"},
-			expectedOut:   "Error: open fail.yaml: no such file or directory",
+			expectedOut:   "error reading YAML file(s)",
 			expectedError: "",
 		},
 	}

pkg/generator.go

@@ -24,12 +24,12 @@ func GenerateJsonSchema(config *Config) error {
 	for _, filePath := range config.input {
 		content, err := os.ReadFile(filePath)
 		if err != nil {
-			return err
+			return errors.New("error reading YAML file(s)")
 		}
 
 		var node yaml.Node
 		if err := yaml.Unmarshal(content, &node); err != nil {
-			return errors.New("error reading YAML file(s)")
+			return errors.New("error unmarshaling YAML")
 		}
 
 		if len(node.Content) == 0 {
@@ -75,10 +75,13 @@ func GenerateJsonSchema(config *Config) error {
 		return err
 	}
 
+	// Write the JSON schema to the output file
 	outputPath := config.outputPath
 	if err := os.WriteFile(outputPath, jsonBytes, 0644); err != nil {
-		return fmt.Errorf("error writing JSON schema to file '%s': %v", outputPath, err)
+		return errors.New("error writing schema to file")
 	}
 
+	fmt.Println("JSON schema successfully generated")
+
 	return nil
 }

pkg/generator_test.go

@@ -2,6 +2,7 @@ package pkg
 
 import (
 	"encoding/json"
+	"errors"
 	"os"
 	"testing"
 
@@ -37,3 +38,68 @@ func TestGenerateJsonSchema(t *testing.T) {
 
 	os.Remove(config.outputPath)
 }
+
+func TestGenerateJsonSchema_Errors(t *testing.T) {
+	tests := []struct {
+		name        string
+		config      *Config
+		setupFunc   func() error
+		cleanupFunc func() error
+		expectedErr error
+	}{
+		{
+			name: "Invalid draft version",
+			config: &Config{
+				input: []string{"../testdata/basic.yaml"},
+				draft: 5,
+			},
+			expectedErr: errors.New("invalid draft version"),
+		},
+		{
+			name: "Missing file",
+			config: &Config{
+				input: []string{"missing.yaml"},
+				draft: 2020,
+			},
+			expectedErr: errors.New("error reading YAML file(s)"),
+		},
+		{
+			name: "Fail Unmarshal",
+			config: &Config{
+				input:      []string{"../testdata/fail"},
+				outputPath: "testdata/failure/output_readonly_schema.json",
+				draft:      2020,
+			},
+			expectedErr: errors.New("error unmarshaling YAML"),
+		},
+		{
+			name: "Read-only filesystem",
+			config: &Config{
+				input:      []string{"../testdata/basic.yaml"},
+				outputPath: "testdata/failure/output_readonly_schema.json",
+				draft:      2020,
+			},
+			expectedErr: errors.New("error writing schema to file"),
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if tt.setupFunc != nil {
+				err := tt.setupFunc()
+				assert.NoError(t, err)
+			}
+
+			err := GenerateJsonSchema(tt.config)
+			assert.Error(t, err)
+			if err != nil {
+				assert.Contains(t, err.Error(), tt.expectedErr.Error())
+			}
+
+			if tt.cleanupFunc != nil {
+				err := tt.cleanupFunc()
+				assert.NoError(t, err)
+			}
+		})
+	}
+}

pkg/schema_test.go

@@ -108,7 +108,7 @@ func TestGetSchemaURL(t *testing.T) {
 		},
 		{
 			name:        "Invalid Draft",
-			draft:       3, // assuming 3 is an invalid draft version
+			draft:       5,
 			expectedURL: "",
 			expectedErr: errors.New("invalid draft version. Please use one of: 4, 6, 7, 2019, 2020"),
 		},

testdata/fail

@@ -0,0 +1 @@
+{