Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cog title bar doesn't update with Shoutcast stream #335

Closed
maya923 opened this issue Dec 6, 2022 · 0 comments
Closed

Cog title bar doesn't update with Shoutcast stream #335

maya923 opened this issue Dec 6, 2022 · 0 comments
Assignees

Comments

@maya923
Copy link

maya923 commented Dec 6, 2022

Describe
When I listen to a Shoutcast stream, the title bar does not reflect the current song.

Screenshots
See screenshot. The station is SEB, Sleepbot Environmental Broadcast, @ http://www.sleepbot.com/seb. Web browser shows currently playing song, along with Cog, but Cog's title bar shows the last song it was stopped on.

Version information:*

  • macOS version: Monterey v12.6.1
  • Cog version: Version 2722 (2722-g5e0a3308)

Screen Shot 2022-12-06 at 6 06 20 PM

@kode54 kode54 closed this as completed in e1fb7b9 Dec 10, 2022
kode54 added a commit that referenced this issue Dec 10, 2022
This change had several components. For one, the delay of the dispatch
was increased from 5 milliseconds to 50 milliseconds. Two, the post to
the notification center was included in the delayed dispatch, so that
retains the PlaylistEntry object. Finally, the playlistController's
currentEntry object is reassigned from the input PlaylistEntry object,
which facilitates all watchers which are observing that variable for
updates. This final step also retains self for the callback, which
should be fine, since it's a quick dispatch with a short delay.

Fixes #335

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants