Adds decimal digits to volume slider tooltip #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the volume slider tooltip so that: -If the volume slider falls below 10%, the volume tooltip will display one decimal digit of precision (e.g. 3.4%). -Else if the volume slider falls below 1%, display one decimal digit of precision (e.g. 0.34%). -Otherwise display the volume slider tooltip as normal. This helps show changes in volume between 0% and 10% where a change in volume isn't shown in the UI but is heard (especially when the "Limit volume control to 100%" option is unchecked in the "Output" Preferences submenu.
Fix variable declaration
|
I will squash and merge when this validates. |
|
Oh, I defined it out of scope. Thanks for fixing it! |
kode54
added a commit
that referenced
this pull request
Jun 1, 2023
* Adds decimal digits to volume slider tooltip Modifies the volume slider tooltip so that: -If the volume slider falls below 10%, the volume tooltip will display one decimal digit of precision (e.g. 3.4%). -Else if the volume slider falls below 1%, display one decimal digit of precision (e.g. 0.34%). -Otherwise display the volume slider tooltip as normal. This helps show changes in volume between 0% and 10% where a change in volume isn't shown in the UI but is heard (especially when the "Limit volume control to 100%" option is unchecked in the "Output" Preferences submenu. * Update VolumeSlider.m Fix variable declaration --------- Co-authored-by: Christopher Snowhill <chris@kode54.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the volume slider tooltip so that:
-If the volume slider falls below 10%, the volume tooltip will display one decimal digit of precision (e.g. 3.4%).
-Else if the volume slider falls below 1%, display one decimal digit of precision (e.g. 0.34%).
-Otherwise display the volume slider tooltip as normal.
This helps show changes in volume between 0% and 10% where a change in volume isn't shown in the UI but is heard (especially when the "Limit volume control to 100%" option is unchecked in the "Output" Preferences submenu.