Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Exporting starts multiple downloads of same file #89

Closed
uku1928 opened this issue Aug 10, 2022 · 1 comment
Closed

BUG: Exporting starts multiple downloads of same file #89

uku1928 opened this issue Aug 10, 2022 · 1 comment

Comments

@uku1928
Copy link

uku1928 commented Aug 10, 2022

Bug description
This bug downloads exported files more times than necessary.

To Reproduce
Steps to reproduce the behavior:

  1. Export
    1a. Open another file (optional?)
  2. Export again

Expected behavior
The file should only be downloaded once per export.

Desktop

  • OS: Windows 10
  • Browser: Chrome 103.0.5060.134 (Official Build) (64-bit) (cohort: Stable)

Additional context
The amount of files downloaded is the amount of "Export" clicked since last refresh.
matthewd673 added a commit to matthewd673/pixel-editor that referenced this issue Aug 24, 2022
@matthewd673
Only register export click event once (lospec#89)
45016fb
@matthewd673 matthewd673 mentioned this issue Aug 24, 2022
Merged
unsettledgames added a commit that referenced this issue Aug 25, 2022
@unsettledgames
Merge pull request #92 from matthewd673/master
8a42ddd 
Only register export click event once (#89)
@unsettledgames
Copy link
Collaborator

Fixed by #92, related to #101, so keeping 101 open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@unsettledgames @uku1928