Updates league/commonmark to ^0.18 #1
Conversation
sanpii
changed the title
|
@sanpii this seems to break compatibility you should do like commonmark extras does: "^0.11|^0.12|^0.13|^0.14|^0.15|^0.16|^0.17|^0.18" |
|
@sanpii also, you should never create PRs from master branch, it may add commits to PR you did not intend, as it's linked with your |
|
@lossendae ping; @sanpii ping; |
tests/RendererTest.php
Outdated
| use Lossendae\CommonMark\TaskLists\{ | ||
| TaskListsParser, | ||
| TaskListsCheckboxRenderer | ||
| }; |
There was a problem hiding this comment.
composer.json declares php 5.4, this definately is not supported there
|
looks to me this requires more changes |
|
@lossendae you should probably indicate the direction:
|
to add commonmark 0.18 support: - lossendae/commonmark-task-lists#1
|
Thank you for your feedbacks. It’s fixed. |
| @@ -0,0 +1,109 @@ | |||
| <?php declare(strict_types = 1); | |||
There was a problem hiding this comment.
declare(strict_types = 1); is not available in php 5.4
| "league/commonmark": ">=0.11,<0.19" | ||
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "^7.1" |
There was a problem hiding this comment.
that version of phpunit is not php 5.4 compatible. altho for tests probably ok to have higher php requirement, even it seems super odd.
|
@colinodell here's another extension I rely on, but seems abandoned. |
|
@colinodell did you notice my previous question? my question would be: perhaps transfer this extension also to official group, then at least can add maintainers more easily even if original devs dissapear for example this code renders funny: [x] ee
[x] lv
[x] lt |
|
getting such error with 0.18 (can't upgrade due this extension not updated to newer) from such markup: *list*
[x] Ilmateadeand it's actually fatal error, as nothing is rendered, but not clear where it invoked die. |
No description provided.