make breakpoints optional and deal with undefined state

lost-pixel · Nov 18, 2023 · e8fef20 · e8fef20
1 parent 49c6acb
commit e8fef20
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 9 deletions.
diff --git a/src/config.ts b/src/config.ts
@@ -56,7 +56,7 @@ const PageScreenshotParameterSchema = z.object({
    * @example
    * [ 320, 768, 1280 ]
    */
-  breakpoints: z.array(z.number()),
+  breakpoints: z.array(z.number()).optional(),
 
   /**
    * Define a custom viewport for the page
@@ -118,7 +118,7 @@ const LadleShotsSchema = z.object({
    * @example
    * [ 320, 768, 1280 ]
    */
-  breakpoints: z.array(z.number()).default([]).optional(),
+  breakpoints: z.array(z.number()).optional(),
 });
 
 const HistoireShotsSchema = z.object({
@@ -254,7 +254,7 @@ const BaseConfigSchema = z.object({
    * @example
    * [ 320, 768, 1280 ]
    */
-  breakpoints: z.array(z.number()).default([]),
+  breakpoints: z.array(z.number()).optional(),
 
   /**
    * Number of concurrent shots to take

diff --git a/src/crawler/ladleScreenshots.ts b/src/crawler/ladleScreenshots.ts
@@ -45,7 +45,7 @@ export const generateLadleShotItems = (
       mask: mask ?? [],
     };
 
-    if (!breakpoints || breakpoints.length === 0) {
+    if (breakpoints.length === 0) {
       return [shotItem];
     }
 

diff --git a/src/crawler/pageScreenshots.ts b/src/crawler/pageScreenshots.ts
@@ -76,7 +76,7 @@ export const generatePageShotItems = (
       mask: [...(mask ?? []), ...(page.mask ?? [])],
     };
 
-    if (!breakpoints || breakpoints.length === 0) {
+    if (breakpoints.length === 0) {
       return [baseShotItem];
     }
 

diff --git a/src/crawler/storybook.ts b/src/crawler/storybook.ts
@@ -317,15 +317,16 @@ export const generateStorybookShotItems = (
         mask: [...(mask ?? []), ...(story.parameters?.lostpixel?.mask ?? [])],
       };
 
-      const storyLevelBreakpoints = story.parameters?.lostpixel?.breakpoints;
+      const storyLevelBreakpoints =
+        story.parameters?.lostpixel?.breakpoints ?? [];
 
       const breakpoints = selectBreakpoints(
         config.breakpoints,
         modeBreakpoints,
         storyLevelBreakpoints,
       );
 
-      if (!breakpoints || breakpoints.length === 0) {
+      if (breakpoints.length === 0) {
         return [baseShotItem];
       }
 

diff --git a/src/shots/utils.ts b/src/shots/utils.ts
@@ -135,7 +135,7 @@ export const selectBreakpoints = (
   topLevelBreakpoints?: number[],
   modeBreakpoints?: number[],
   shotBreakpoints?: number[],
-): number[] | undefined => {
+) => {
   if (shotBreakpoints && shotBreakpoints.length > 0) {
     return shotBreakpoints;
   }
@@ -144,7 +144,7 @@ export const selectBreakpoints = (
     return modeBreakpoints;
   }
 
-  return topLevelBreakpoints;
+  return topLevelBreakpoints ?? [];
 };
 
 export const generateSizeLabel = (breakpoint: number): string => {