introduce constants

lost-pixel · Nov 18, 2023 · ecf47d9 · ecf47d9
1 parent a23697d
commit ecf47d9
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 14 deletions.
diff --git a/src/constants.ts b/src/constants.ts
@@ -0,0 +1 @@
+export const notSupported = 'not supported';
diff --git a/src/crawler/histoireScreenshots.ts b/src/crawler/histoireScreenshots.ts
@@ -3,6 +3,7 @@ import axios from 'axios';
 import { log } from '../log';
 import { config, isPlatformModeConfig } from '../config';
 import { type ShotItem } from '../types';
+import { notSupported } from '../constants';
 
 type HistoireStory = {
   id: string;
@@ -37,14 +38,14 @@ const generateShotItemsForStory = (
       shotName: variantShotName,
       url: `${baseUrl}/__sandbox.html?storyId=${story.id}&variantId=${variant.id}`,
       filePathBaseline: isPlatformModeConfig(config)
-        ? 'not supported'
+        ? notSupported
         : path.join(config.imagePathBaseline, `${variantShotName}.png`),
       filePathCurrent: path.join(
         config.imagePathCurrent,
         `${variantShotName}.png`,
       ),
       filePathDifference: isPlatformModeConfig(config)
-        ? 'not supported'
+        ? notSupported
         : path.join(config.imagePathDifference, `${variantShotName}.png`),
       threshold: config.threshold,
     });

diff --git a/src/crawler/ladleScreenshots.ts b/src/crawler/ladleScreenshots.ts
@@ -4,6 +4,7 @@ import { config, isPlatformModeConfig, type Mask } from '../config';
 import type { ShotItem } from '../types';
 import { selectBreakpoints, generateSizeLabel } from '../shots/utils';
 import type { Story } from './storybook';
+import { notSupported } from '../constants';
 
 export const generateLadleShotItems = (
   baseUrl: string,
@@ -31,14 +32,14 @@ export const generateLadleShotItems = (
         : ladleStory.id,
       url: `${ladleUrl}?story=${ladleStory.story}&mode=preview`,
       filePathBaseline: isPlatformModeConfig(config)
-        ? 'not supported'
+        ? notSupported
         : `${path.join(config.imagePathBaseline, ladleStory.story)}.png`,
       filePathCurrent: `${path.join(
         config.imagePathCurrent,
         ladleStory.story,
       )}.png`,
       filePathDifference: isPlatformModeConfig(config)
-        ? 'not supported'
+        ? notSupported
         : `${path.join(config.imagePathDifference, ladleStory.story)}.png`,
       threshold: config.threshold,
       mask: mask ?? [],
@@ -59,7 +60,7 @@ export const generateLadleShotItems = (
         breakpointGroup: ladleStory.story,
         url: `${ladleUrl}?story=${ladleStory.story}&mode=preview&width=${breakpoint}`,
         filePathBaseline: isPlatformModeConfig(config)
-          ? 'not supported'
+          ? notSupported
           : `${path.join(
               config.imagePathBaseline,
               ladleStory.story,
@@ -69,7 +70,7 @@ export const generateLadleShotItems = (
           ladleStory.story,
         )}${sizeLabel}.png`,
         filePathDifference: isPlatformModeConfig(config)
-          ? 'not supported'
+          ? notSupported
           : `${path.join(
               config.imagePathDifference,
               ladleStory.story,

diff --git a/src/crawler/pageScreenshots.ts b/src/crawler/pageScreenshots.ts
@@ -10,6 +10,7 @@ import {
 } from '../config';
 import type { ShotItem } from '../types';
 import { selectBreakpoints, generateSizeLabel } from '../shots/utils';
+import { notSupported } from '../constants';
 
 const generateBrowserConfig = (page: PageScreenshotParameter) => {
   const browserConfig = config.configureBrowser?.({
@@ -62,11 +63,11 @@ export const generatePageShotItems = (
         : page.name,
       url: path.join(baseUrl, page.path),
       filePathBaseline: isPlatformModeConfig(config)
-        ? 'not supported'
+        ? notSupported
         : `${path.join(config.imagePathBaseline, page.name)}.png`,
       filePathCurrent: `${path.join(config.imagePathCurrent, page.name)}.png`,
       filePathDifference: isPlatformModeConfig(config)
-        ? 'not supported'
+        ? notSupported
         : `${path.join(config.imagePathDifference, page.name)}.png`,
       browserConfig: generateBrowserConfig(page),
       threshold: page.threshold ?? config.threshold,
@@ -90,14 +91,14 @@ export const generatePageShotItems = (
         breakpointGroup: page.name,
         url: path.join(baseUrl, page.path),
         filePathBaseline: isPlatformModeConfig(config)
-          ? 'not supported'
+          ? notSupported
           : `${path.join(config.imagePathBaseline, page.name)}${sizeLabel}.png`,
         filePathCurrent: `${path.join(
           config.imagePathCurrent,
           page.name,
         )}${sizeLabel}.png`,
         filePathDifference: isPlatformModeConfig(config)
-          ? 'not supported'
+          ? notSupported
           : `${path.join(
               config.imagePathDifference,
               page.name,

diff --git a/src/crawler/storybook.ts b/src/crawler/storybook.ts
@@ -7,6 +7,7 @@ import { type Mask, config, isPlatformModeConfig } from '../config';
 import { getBrowser } from '../utils';
 import { log } from '../log';
 import { selectBreakpoints, generateSizeLabel } from '../shots/utils';
+import { notSupported } from '../constants';
 
 export type StoryParameters = {
   lostpixel?: {
@@ -302,11 +303,11 @@ export const generateStorybookShotItems = (
         importPath: story.importPath,
         url: `${iframeUrl}?id=${story.id}&viewMode=story`,
         filePathBaseline: isPlatformModeConfig(config)
-          ? 'not supported'
+          ? notSupported
           : path.join(config.imagePathBaseline, fileNameWithExt),
         filePathCurrent: path.join(config.imagePathCurrent, fileNameWithExt),
         filePathDifference: isPlatformModeConfig(config)
-          ? 'not supported'
+          ? notSupported
           : path.join(config.imagePathDifference, fileNameWithExt),
         browserConfig: generateBrowserConfig(story),
         threshold: story.parameters?.lostpixel?.threshold ?? config.threshold,
@@ -340,11 +341,11 @@ export const generateStorybookShotItems = (
           breakpoint,
           breakpointGroup: story.id,
           filePathBaseline: isPlatformModeConfig(config)
-            ? 'not supported'
+            ? notSupported
             : path.join(config.imagePathBaseline, fileNameWithExt),
           filePathCurrent: path.join(config.imagePathCurrent, fileNameWithExt),
           filePathDifference: isPlatformModeConfig(config)
-            ? 'not supported'
+            ? notSupported
             : path.join(config.imagePathDifference, fileNameWithExt),
           viewport: {
             width: breakpoint,