-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewport option doesn't work #269
Comments
Hey @JakubBlazity! What's your exact use case for the viewport? Do you want to make the screenshots for specific size of browser tab always or it's more in the direction of making shots with different breakpoints? We have a feature for breakpoints, but the viewport as you noticed might not work as expected. We need to work on this! |
@d-ivashchuk |
with our breakpoint shots implementation, we went in the direction of horizontal breakpoints, meaning that you can set that up horizontally.
I don't think setting the viewport in page mode is possible now(we missed something in the implementation), but it should be quite easy to fix. If you want to make a contribution I'd be happy to assist! |
I had a look at the codebase and there's a condition that checks if module.exports = {
configureBrowser: (browser) => browser,
}; |
Hey @jerico-wf! What exactly started to work with configureBrowser present? Might help us fixing it, thanks! I'd also be glad to accept a PR 🙌🏼 |
Hey @d-ivashchuk, just responding from my main account. I found this condition in the code which appears to require |
Awesome work finding this out, I don't think there is some good reasoning behind this! Would appreciate the PR that fixes this so you don't need to use the hack 🙌🏼 |
@d-ivashchuk sure thing - let me know what you think about this 🙏 #273 |
Bug description
Viewport option doesn't have impact on generated image size
How to reproduce
npx lost-pixel
Expected behavior
Generated image should have specified size
Lost Pixel information
No response
lost-pixel logs from CI
No response
The text was updated successfully, but these errors were encountered: