Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helper.py #23

Merged
merged 1 commit into from Oct 11, 2022
Merged

Update helper.py #23

merged 1 commit into from Oct 11, 2022

Conversation

lostb053
Copy link
Owner

No description provided.

@lostb053 lostb053 merged commit 8ebdc57 into main Oct 11, 2022
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 11, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 15.85 🙂 15.85 🙂 0.00
Method Length 133.55 😞 133.55 😞 0.00
Working memory 7.83 🙂 7.83 🙂 0.00
Quality 46.91% 😞 46.91% 😞 0.00%
Other metrics Before After Change
Lines 375 375 0
Changed files Quality Before Quality After Quality Change
anibot/utils/helper.py 46.91% 😞 46.91% 😞 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
anibot/utils/helper.py get_btns 29 😞 661 ⛔ 16 ⛔ 17.46% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
anibot/utils/helper.py control_user 30 😞 239 ⛔ 23.38% ⛔ Refactor to reduce nesting. Try splitting into smaller methods
anibot/utils/helper.py media_to_image 16 🙂 346 ⛔ 12 😞 33.47% 😞 Try splitting into smaller methods. Extract out complex expressions
anibot/utils/helper.py update_pics_cache 17 🙂 269 ⛔ 12 😞 35.09% 😞 Try splitting into smaller methods. Extract out complex expressions
anibot/utils/helper.py check_user 23 😞 142 😞 41.18% 😞 Refactor to reduce nesting. Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant