Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Bengali locale #168

Merged
merged 5 commits into from Oct 15, 2022
Merged

Added Bengali locale #168

merged 5 commits into from Oct 15, 2022

Conversation

soumyaDghosh
Copy link
Contributor

I have added bengali locale. Also would like to edit and make some changes in Hindi locale, and add Tamil, Malayalam, Telugu and atleast 12 Bharatiya languages

@lostdesign
Copy link
Owner

hi @soumyatheman thanks for your PR!
I am about to merge #171 which adds new strings - could you add these already?

Regarding the other languages, sure go ahead! Thank you so much!
Also, would be cool if you can add the discord to discuss things there - I respond there much quicker!
https://discord.gg/uNjJzZvccr

Copy link
Owner

@lostdesign lostdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed the new translations, can you check the new format. Every translation now also has a command section and settings was extended with an allowPrerelease block. Thanks in advance.

@soumyaDghosh
Copy link
Contributor Author

Sorry, It's currently Durga Puja aka Sharad Navaratri going on. So, I am very busy, to enjoy the Puja. I'll be on work again after the Puja ends. Thanks for accepting my PR. ধন্যবাদ

@lostdesign
Copy link
Owner

Sorry, It's currently Durga Puja aka Sharad Navaratri going on. So, I am very busy, to enjoy the Puja. I'll be on work again after the Puja ends. Thanks for accepting my PR. ধন্যবাদ

No worries! Enjoy your time and thanks for letting me know 🫶

@soumyaDghosh
Copy link
Contributor Author

There is some issue in en_US locale. Please check that out. I don't understand the language.

"commands": {
"no_result": "No se encontró ningún comando coincidente",
"type_slash": "Tipo / para bloques",
"blocks": {
"h1": {
"title": "Título 1",
"description": "Un encabezado de nivel uno."
},
"h2": {
"title": "Título 2",
"description": "Un encabezado de nivel dos."
},
"h3": {
"title": "Título 3",
"description": "Un encabezado de nivel tres."
},
"bold": {
"title": "Negrita",
"description": "Escribir su texto en negrita."
},
"italic": {
"title": "Cursiva",
"description": "Escribir su texto en cursiva."
},
"task": {
"title": "Que hacer",
"description": "Agrega una casilla de verificación de tareas pendientes."
},
"unorderedList": {
"title": "Lista",
"description": "Una lista desordenada."
},
"codeBlock": {
"title": "Código",
"description": "Agrega un bloque de código."
}

@lostdesign
Copy link
Owner

@soumyatheman good catch, fixed it and merged #181

@soumyaDghosh
Copy link
Contributor Author

All Done. I hope everything is fine now

README.md Outdated


### This is a request from the Bengali translator of this app to all the Bharatiya users using this project, if you can or have the knowledge of your language or Sanskrit, please let me know. So, that we together can make better terms for every Technical word. Tag me as @soumyatheman in github, and open an issue to connect with me.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this into a discussion instead of a comment in the readme please? See https://github.com/lostdesign/linked/discussions/categories/01-general

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I'll do so,

"title": "তথ্যভাণ্ডার সূচক",
"hint": "সূচকীকরণের সূচনা করা হলে লিঙ্কড আপনার প্রত্যেকদিনের টীকাগুলিকে বিবেচনা করবে এবং তথ্য সুচকে যুক্ত করবে। এটি কেবলমাত্র একবারই করার দরকার হবে v1.4.0 তে পরিবর্ধন করার পর। আমাদের ওয়েবসাইটে এই বিষয়ে বিস্তারিত পাবেন।",
"start": "তথ্যভাণ্ডারের মেরামতি করুন"
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you format the json please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's the same with en_US. I rechecked it, it's same with en_US. Please show me the error.(Highlight)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bildschirmfoto 2022-10-11 um 08 48 36

@lostdesign lostdesign merged commit d5ab379 into lostdesign:master Oct 15, 2022
@lostdesign
Copy link
Owner

I will fix it, all good. Merging your PR now - thanks :)

@soumyaDghosh
Copy link
Contributor Author

I will fix it, all good. Merging your PR now - thanks :)

I'm extremely sorry for being late. My college has started after Durga Puja vacation ended, I was also ill for almost a week. So, extremely sorry.

@lostdesign
Copy link
Owner

I will fix it, all good. Merging your PR now - thanks :)

I'm extremely sorry for being late. My college has started after Durga Puja vacation ended, I was also ill for almost a week. So, extremely sorry.

No need to be sorry. I am grateful for your contribution and it is really a minor issue.

You've been helpful so don't worry. Enjoy your holidays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants