New Typhoeus Adapter #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've created a new Typhoeus adapter for Faraday here: - https://github.com/dleavitt/faraday-typhoeus (happy to move it under the Faraday org if you'd prefer.) - https://rubygems.org/gems/faraday-typhoeus It ports the (apparently unmaintained) adapter bundled with Typhoeus to work with Faraday 2. It also adds support for streaming. The adapter specs pass, and I think in general it's pretty adequate.
|
Supports compression and reason phrase parsing now too. |
iMacTia
approved these changes
Apr 18, 2022
There was a problem hiding this comment.
@dleavitt great work creating the adapter and adding new functioality (especially streaming!) in the process 👏
Really happy to showcase this in the awesome-faraday collection and no need to move it under the lostisland organisation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a new Typhoeus adapter for Faraday here:
It ports the (seemingly unmaintained) adapter bundled with Typhoeus to work with Faraday 2. It also adds support for streaming. It's documented (mostly cribbed examples), the adapter specs pass, and I think in general it's pretty adequate?