New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP.rb adapter #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small issues, but this looks solid.
faraday-http.gemspec
Outdated
@@ -37,8 +37,14 @@ Gem::Specification.new do |spec| | |||
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } | |||
spec.require_paths = ['lib'] | |||
|
|||
# spec.add_dependency 'faraday', '~> 1.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# spec.add_dependency 'faraday', '~> 1.0' |
Just waiting for lostisland/faraday#941 to be merged before merging this in, will need to change the |
@iMacTia That branch is now merged, this PR is ready for its next step: Gemfile fix. |
Thanks! Will try to have a look today otherwise tomorrow will be done 😁 |
Description
This adds an adapter for HTTP - The Gem! a.k.a http.rb
Based on the work from @PandaWhisperer in PandaWhisperer/faraday#1