Honor Content-Type charset #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xkwd
commented
Dec 2, 2021
| @@ -5,7 +5,7 @@ require: | |||
| AllCops: | |||
| DisplayCopNames: true | |||
| DisplayStyleGuide: true | |||
| TargetRubyVersion: 2.4 | |||
| TargetRubyVersion: 2.6 | |||
There was a problem hiding this comment.
Updated this based on the minimum Ruby version in that matrix
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #6
The
Net::HTTPadapter does not seem to do any encoding transformation of the body string when the Content-Type charset is given. Forcing encoding on the response body has been picked as a workaround for that.