Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor Encoding references to avoid faraday-encoding conflicts #18

Merged
merged 1 commit into from
Apr 10, 2022

Conversation

nbibler
Copy link
Contributor

@nbibler nbibler commented Apr 10, 2022

This adds an explicit top-level namespace identification to all Encoding references (via ::Encoding) in this library.

This change ensures that the top-level, Ruby-provided Encoding class is used rather than a faraday-encoding-defined Faraday::Encoding class if both libraries are loaded in an application.

See #17.

@iMacTia iMacTia merged commit 7f50fcf into lostisland:main Apr 10, 2022
@nbibler nbibler deleted the fix/encoding-collision branch April 10, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants