-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Use Ruby 3.3 for linting #35
Conversation
RuboCop is set to use 2.6 syntax rules in any case.
78b1043
to
76ca526
Compare
Next release will drop Ruby 2.6 and 2.7 anyway, so feel free to remove them in this PR if it helps getting CI green 👍 |
76ca526
to
638ee1e
Compare
The real reason was "used a bundled Bundler which had some older issues", but now, we got rid of the 2.6, 2.7 from the CI matrix. Should we bump the gemspec min required Ruby version, too, @iMacTia ? |
Yes we'll need to bump it in the gem spec and also in the rubocop.yml file. |
@iMacTia I will refrain from checking for version restriction on the net-http gem, but the rest of the things are here, and I will merge. |
RuboCop is set to use 2.6 syntax rules in any case.
Turned out to need a newer RuboCop, and newer plugins, and after that, it was ready to be used.