Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Faraday::UploadIO while rewinding #37

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Apr 12, 2024

Summary

We're currently checking for defined?(UploadIO), which in the absence of the faraday-multipart will point to the now deprecated constant defined in multipart-post. With this change, we'll now explicitly check for Faraday::UploadIO which automatically points to the right constant based on the version of multipart-post in use.

Fixes #36

@iMacTia iMacTia self-assigned this Apr 12, 2024
Copy link

@jimeh jimeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have my approval at least :)

Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah!

@olleolleolle olleolleolle added this pull request to the merge queue Apr 12, 2024
Merged via the queue into main with commit ce15807 Apr 12, 2024
7 checks passed
@olleolleolle olleolleolle deleted the mg/#36-fix-upload-io-deprecation-warn branch April 12, 2024 13:48
@jimeh
Copy link

jimeh commented Apr 15, 2024

Any ETA on when this might drop in a new release? :)

@iMacTia
Copy link
Member Author

iMacTia commented Apr 17, 2024

@olleolleolle released v2.2.1 which includes this fix 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning about ::UploadIO constant when used without faraday-multipart gem
3 participants