Ability to configure net http persistent client

[ajsharp]

Currently, it's not possibly through the api to configure the idle_timeout, because the faraday net http persistent adapter instantiates a new Net::HTTP::Persistent instance on each request. The library is smart enough to use the same connection across instances for performing http requests, but it configuration options such as idle_timeout must be configured on a per-object basis. Has this been an issue with other adapters, that needed custom configuration passed to it? Thanks.

[mislav]

👍

I'd like to have the ability to configure the connection as well. Not necessarily through request options in env, but at adapter instantiation time. Maybe via a configuration block?

conn.adapter :net_http_persistent do |http|
  http.stuff = :moo
end

[ajsharp]

Ooh yea, I like the block configuration interface.

[rehevkor5]

I am encountering similar difficulties as I'm attempting to implement an adapter for Excon that enables persistent connections. If the adapter re-uses the same Excon object multiple times, then it is difficult to ensure that new settings on the individual request take effect on the Excon object. If I make the adapter create a new object each time, then as you mention the initial settings must be given to the object each time. The behavior of Faraday vs. the adapter in terms of globally configured settings vs. per-request settings (some of them probably can't be per-request) seems a bit unclear to me.

[justinvj15]

👍

Is this implemented ?

Thanks

[iMacTia]

This is now implemented and released as of v0.11.0 😃
See https://github.com/lostisland/faraday#ad-hoc-adapters-customization for details