Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many typhoeus tests failing with invalid ethon ssl options #274

Closed
pravi opened this issue May 19, 2013 · 3 comments
Closed

many typhoeus tests failing with invalid ethon ssl options #274

pravi opened this issue May 19, 2013 · 3 comments

Comments

@pravi
Copy link

pravi commented May 19, 2013

test_POST_send_url_encoded_params(Adapters::TyphoeusTest):
Ethon::Errors::InvalidOption: The option: disable_ssl_peer_verification is invalid.
Please try ssl_verifypeer instead of disable_ssl_peer_verification.
usr/lib/ruby/vendor_ruby/ethon/easy.rb:234:in `block in set_attributes'
    /usr/lib/ruby/vendor_ruby/ethon/easy.rb:231:in `each_pair'
    /usr/lib/ruby/vendor_ruby/ethon/easy.rb:231:in `set_attributes'
    /usr/lib/ruby/vendor_ruby/ethon/easy/http/actionable.rb:79:in `setup'
    /usr/lib/ruby/vendor_ruby/ethon/easy/http/post.rb:16:in `setup'
    /usr/lib/ruby/vendor_ruby/ethon/easy/http.rb:39:in `http_request'
    /usr/lib/ruby/vendor_ruby/typhoeus/easy_factory.rb:51:in `get'
    /usr/lib/ruby/vendor_ruby/typhoeus/hydra/addable.rb:19:in `add'
    /usr/lib/ruby/vendor_ruby/typhoeus/hydra/memoizable.rb:40:in `add'
    /usr/lib/ruby/vendor_ruby/typhoeus/hydra/cacheable.rb:8:in `add'
    /usr/lib/ruby/vendor_ruby/typhoeus/hydra/block_connection.rb:30:in `add'
    /usr/lib/ruby/vendor_ruby/typhoeus/hydra/stubbable.rb:21:in `add'
    /usr/lib/ruby/vendor_ruby/typhoeus/hydra/before.rb:26:in `add'
    /usr/lib/ruby/vendor_ruby/typhoeus/hydra/runnable.rb:18:in `block (2 levels) in run'
    /usr/lib/ruby/vendor_ruby/typhoeus/hydra/runnable.rb:17:in `map'
    /usr/lib/ruby/vendor_ruby/typhoeus/hydra/runnable.rb:17:in `block in run'
    /usr/lib/ruby/vendor_ruby/typhoeus/hydra/runnable.rb:15:in `loop'
    /usr/lib/ruby/vendor_ruby/typhoeus/hydra/runnable.rb:15:in `run'
    /usr/lib/ruby/vendor_ruby/typhoeus/hydra/memoizable.rb:50:in `run'
    /tmp/buildd/ruby-faraday-0.8.7/lib/faraday/adapter/typhoeus.rb:23:in `perform_request'
    /tmp/buildd/ruby-faraday-0.8.7/lib/faraday/adapter/typhoeus.rb:14:in `call'
    /tmp/buildd/ruby-faraday-0.8.7/lib/faraday/response.rb:8:in `call'
    /tmp/buildd/ruby-faraday-0.8.7/lib/faraday/request/url_encoded.rb:14:in `call'
    /tmp/buildd/ruby-faraday-0.8.7/lib/faraday/request/multipart.rb:13:in `call'
    /tmp/buildd/ruby-faraday-0.8.7/lib/faraday/connection.rb:247:in `run_request'
    /tmp/buildd/ruby-faraday-0.8.7/lib/faraday/connection.rb:112:in `post'
    /tmp/buildd/ruby-faraday-0.8.7/test/adapters/integration.rb:104:in `test_POST_send_url_encoded_params'
@mislav
Copy link
Contributor

mislav commented May 20, 2013

What's your bundle show typhoeus? Can you try the "0.8" branch, which contains some test suite fixes?

It appears you have a version of Typhoeus in your /usr/lib/ruby/vendor_ruby directory, but keep in mind the built-in Faraday adapter only supports Typhoeus 0.3. Newer versions of Typhoeus ship with their own Faraday adapter.

@pravi
Copy link
Author

pravi commented May 20, 2013

typhoeus version in /usr/lib/ruby/vendor_ruby is 0.6.3 (that is the default location for ruby libraries in debian and I'm packaging faraday for debian). May be you can add a check for typhoeus version and skip tests if typhoeus is newer than 0.3. I will try 0.8 branch and see if that fixes these tests.

@mislav
Copy link
Contributor

mislav commented May 20, 2013

Typhoeus adapter that ships with Faraday will not be compatible with 0.6.3, not even on the 0.8 branch. Our test suite (script/test) is supposed to use Bundler to ensure that we're testing against the right dependencies. If you run the test files directly (without script/test or bundle exec) there's risk that they might fail due to incompatible dependencies.

@mislav mislav closed this as completed May 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants