-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RuboCop Quest Issue #204
Comments
@d-m-u @onk thanks for your patience, I've resolved a bunch of offences automatically and updated the list above 👍
Thanks ❤️ ! |
I've got the Lint/Loop one. |
I've also got the Style/GuardClause and the Naming/VariableNumber and the Style/CaseEquality thing and the Naming/ConstantName one, and the Style/NumericPredicate and the Lint/AssignmentInCondition and the MultilineTernaryOperator one. I swear that's it though. edit fine also the Naming/PredicateName and the Style/IfUnlessModifier and the Layout/LineLength but I expect that one will be needing a few reviews 😆 |
Gemspec requires ruby min 2.3 from lostisland#223 (comment) original issue is of course lostisland#204
Gemspec requires ruby min 2.3 from #223 (comment) original issue is of course #204
Thank you, everyone! I am declaring a victory: there are now AbcSize + MethodLength left, and those are just set in the TODO file to a current "max" value which we can prune downwards as we go. This was a significant piece of formatting - thanks so much for stepping up and helping out with this. A special round of applause for @onk and @d-m-u who picked up the bulk of the pieces left after @iMacTia did the initial automated push. Closing this Issue feels very good. Thanks! 🌻 /Olle |
Basic Info
We are linting the whole codebase using RuboCop. ✨
This is a list of all the rules in the
.rubocop_todo.yml
when we started. The checkmarks mean "this is fixed and merged to master".If you create a PR to fix one of these, use the
--only
option in RuboCop, to focus the effort on 1 kind of fix. It's so easy to get overwhelmed when reviewing code like this. (If you fix slightly more than that, no biggie. This is all about keeping the changes reviewable.)A workflow
Issue description
(Here - we will add each of the RuboCop Cops in order.)
See #200
The text was updated successfully, but these errors were encountered: