Replace rash with rash_alt #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do faraday_middleware support ruby <= 1.9.2 ? It seem my branch fail in only ruby <= 1.9.2... |
|
@mislav can you check this? We'd like to go ahead with rash_alt in debian. |
|
I've marked this for next release (0.12) as the plan is to remove support for ruby < 1.9.3 |
|
@shishi can you please pull/rebase from master? |
|
I've waited for long time 😄 It's time to be done finally! I'm very glad. |
|
Really sorry about the wait @shishi! |
sfroehler
added a commit
to shipcloud/billwerk
that referenced
this pull request
Aug 1, 2017
See following links for more details: https://github.com/lostisland/faraday_middleware/releases/tag/v0.12.0 lostisland/faraday_middleware#136
dorotheelaugwitz
pushed a commit
to shipcloud/billwerk
that referenced
this pull request
Aug 1, 2017
* Pin faraday_middleware to version 0.12.0 * Replaces rash dependency with rash_alt See following links for more details: https://github.com/lostisland/faraday_middleware/releases/tag/v0.12.0 lostisland/faraday_middleware#136 * amend version lock for faraday_middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Hashie have own Rash, rash gem have problem of conflict namespace. We discussed this from long time ago.
tcocca/rash#9
But there is not any solution, I released rash_alt gem for solving out-of-dependency.
faraday_middleware use both hashie and rash, there is problem for out-of-dependency. This pull request solve this problem.