Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full URL (url.host + url.request_uri) as cache key #195

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

vmanivchuk
Copy link
Contributor

No description provided.

@olleolleolle
Copy link
Member

olleolleolle commented Sep 27, 2019

The "full key" form disambiguates, which is better.

(Keeping the old form around for compatibility - is it necessary, in your opinion? I think it may not be necessary.)

@technoweenie How did this work before? Did site_a.com/path and site-b.com/path return the same cached content? (That's my understanding from this diff.) If yes, then let's apply this immediately. ❤️ 🌴

@vmanivchuk
Copy link
Contributor Author

Keeping the old form for compatibility is necessary because there can be issue with key length. And yes, site_a.com/path and site-b.com/path return the same cached content.

@olleolleolle
Copy link
Member

olleolleolle commented Sep 27, 2019

Would it be acceptable to switch over to this new behavior in an upcoming major version? Update: Ah, keys can be too long for one's cache implementation, yeeees. Thanks for clarifying.

@vmanivchuk
Copy link
Contributor Author

Yes, of course.

@iMacTia
Copy link
Member

iMacTia commented Jan 10, 2020

Wanted to include this in last 0.1x release as it's a pretty good point!

@iMacTia iMacTia merged commit 2a6be6a into lostisland:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants