Update to faraday 1.0 #196
Conversation
| @@ -102,6 +102,8 @@ def update_env(env, request_body, response) | |||
| redirect_to_url = safe_escape(response['location'] || '') | |||
| env[:url] += redirect_to_url | |||
|
|
|||
| ENV_TO_CLEAR.each { |key| env.delete key } | |||
|
|
|||
There was a problem hiding this comment.
This needs to happen before we access env[:body] otherwise it returns the response_body and not the request_body https://github.com/lostisland/faraday/blob/v1.0-rc1/UPGRADING.md
Keep it at ClientError
Faraday 0.16.0 changed it so that env[:body] aliases to either env[:request_body] or env[:response_body] https://github.com/lostisland/faraday/blob/v1.0-rc1/UPGRADING.md
BobbyMcWho
force-pushed
the
update-to-faraday-0.16.0
branch
from
dc3af49
to
0ac945d
Compare
Drop support for jruby and rbinx Don't exclude versions
BobbyMcWho
force-pushed
the
update-to-faraday-0.16.0
branch
from
0ac945d
to
0b8fa5b
Compare
|
@olleolleolle are you maintainer over here too? |
| @@ -15,4 +15,3 @@ class Response | |||
| autoload :ParseYaml, 'faraday_middleware/response/parse_yaml' | |||
| end | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
This file doesn't need to change, does it?
There was a problem hiding this comment.
I think it was my editor automatically removing a duplicate newline. I don't have access to my machine today if you think it needs reverted
Co-Authored-By: Olle Jonsson <olle.jonsson@gmail.com>
.travis.yml
Outdated
| gemfile: | ||
| - Gemfile | ||
| - Gemfile-0.9.rb | ||
| gemfile: Gemfile |
There was a problem hiding this comment.
This should be useless as it's the default value for gemfile
iMacTia
dismissed
their stale review
Dismissing as this PR should not be required anymore now that v0.16 has been rolled back
|
Parking this for now as we've released Faraday v0.17.0 which rolled back to v0.15.4 |
|
Yeah, this will likely target a 1.0 release of faraday_middleware instead. |
faraday_middleware.gemspec
Outdated
| spec.add_dependency 'faraday', ['>= 0.7.4', '< 1.0'] | ||
| spec.add_dependency 'faraday', '~> 0.16.0' |
There was a problem hiding this comment.
faraday 0.17.x and 1.x also use the new namespace.
Technically, 0.17.0 and 0.17.3 i think use the top-level namespace, while 0.17.1 and 0.17.2 provided a shim for the Errors module…
|
Thanks for the work @BobbyMcWho! Now that Faraday 1.0 has been released we can finally get this merged 🎉 |
|
Just noticed the pessimistic operator, I've relaxed that to allow v1.0 as that's the version we want to target. |
The faraday_middleware this is based on made the same change in lostisland/faraday_middleware#196. On Faraday >= 1 referring to `env[:body]` when the status is set will refer to the response body rather than the request body.
Faraday 0.16.0 compatibility, drops support for rubies < 2.3.0, jruby and rubinius