Allow to parse relative url templates. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise Client.ResolveReference will override part of our urls when the endpoints contain path.
|
👍 |
owenthereal
added a commit
that referenced
this pull request
Dec 9, 2013
Allow to parse relative url templates.
|
I'm noticing you added a gopack config file. I know @technoweenie and maybe most of the Go GitHubers are using it :). I hope to get to use it more in the future. |
|
yeah, it was already there but it missed a couple of dependencies. It's a pretty nice projects, I have a couple of things more to add, probably this week, one is vendoring, the other one is aliases, so you can use forks without modifying your go code. |
|
👍 to that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise Client.ResolveReference will override part of our urls when the
endpoints contain path.
The problem is more evident when working with GitHub Enterprise, where the api path is
/api/v3.Sawyer removes that part of the path when go-octokit tries to create hyperlinks.