Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix t.NumFiled() panics for non-struct type #14

Closed
wants to merge 2 commits into from
Closed

Fix t.NumFiled() panics for non-struct type #14

wants to merge 2 commits into from

Conversation

owenthereal
Copy link
Member

Recursively get t.Elem() if it's a pointer type.

@owenthereal
Fix t.NumFiled() panics for non-struct type
a0cdfdf 
Recursively get t.Elem() if it's a pointer type.
@owenthereal owenthereal mentioned this pull request Dec 30, 2013
Closed
@technoweenie
Copy link
Member

Looks fine to me, but I would like a test.

@owenthereal owenthereal mentioned this pull request Jan 10, 2014
Open
@technoweenie
Copy link
Member

Per an earlier conversation, I'm going to reject this. The new hypermedia.Rels should handle this better. It uses interface duck typing to figure out which functions to use to pull hypermedia out of an object. A slice should not respond to any of those.

@technoweenie technoweenie deleted the reflection_fix_on_non_struct_type branch January 21, 2014 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@owenthereal @technoweenie