Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse "date" fields as Time #16

Merged
merged 2 commits into from Dec 19, 2013
Merged

Parse "date" fields as Time #16

merged 2 commits into from Dec 19, 2013

Conversation

pengwynn
Copy link
Member

The GitHub API returns commit date fields as :date. This change will attempt to parse those as proper Time objects like we do :created_at, etc.

Fixes octokit/octokit.rb#381

@pengwynn pengwynn mentioned this pull request Dec 17, 2013
Closed
pengwynn added a commit that referenced this pull request Dec 19, 2013
@pengwynn
Merge pull request #16 from lostisland/parse-date-fields-as-date-time
b667b5e 
Parse "date" fields as Time
@pengwynn pengwynn merged commit b667b5e into master Dec 19, 2013
@pengwynn pengwynn deleted the parse-date-fields-as-date-time branch December 19, 2013 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code Commit Author and Committer Date Fields return raw JSON date format rather than UTC format
2 participants
@pengwynn @md5