This repository has been archived by the owner on Apr 23, 2023. It is now read-only.
Prevent crash due to attempting to unbind service when not currently bound #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecgreb
changed the title
sarahsnow1
suggested changes
Oct 24, 2016
| } | ||
| @Override public void onDisconnect() { | ||
| if (isBound) { | ||
| context.unbindService(this); |
There was a problem hiding this comment.
I think we should set isBound = false here. onServiceDisconnected is not called when the client is unbound normally. According to the docs, onServiceDisconnected is only called when the process hosting the service is killed/crashed.
There was a problem hiding this comment.
Good catch. It appears our crash is coming from when two clients attempt to disconnect at the same time. Updated with the suggested change so the second one will not attempt to call unbindService(this).
sarahsnow1
approved these changes
Oct 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Prevent crash due to attempting to unbind service when not currently bound. Simplify logic to disconnect fused location client and service.
Proposed Changes
LostClientManager.removeClient(LostApiClient)andLostClientManager.disconnect(LostApiClient)into a single method.FusedLocationProviderApiImplto prevent attempts to unbind when service is not bound. FixesIllegalArgumentException.FusedLocationServiceConnectionManager.disconnect()since it was only ever called withnull.FusedLocationProviderService.disconnect(LostApiClient)since disconnecting the client is now handled byLostClientManager.removeClient(LostApiClient)called before disconnecting the service.EventCallbacksmethods inFusedLocationProviderApiImpl.Closes #132