This repository has been archived by the owner on Apr 23, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a bug in which cached data in
LostClientManager
prevented initial locations from being sent to listeners which had been removed and re-added.Proposed Changes
ReportedChanges
class and simplifiesLostClientManager
to update information related to last reported location inline rather than use a transactional style API (void updateReportedValues(ReportedChanges changes)
)ClientManager
API (removes internal state which makesshutdown
unnecessary)LocationRequestReport
to allow simplification ofLostClientManager
internal state (keeps track of last reported location for givenLocationRequest
and listener)FusionEngine
to use recommendedLocation#getElapsedRealtimeNanos
instead of non monotonicLocation#getTime
Clock
interface to use nanos rather than millisHandlerFactory
interface to allow constructor injection and easy mocking in testsCloses #241