chore: revert bridgeless config on example apps

lottie-react-native · Feb 4, 2024 · 155cbc7 · 155cbc7
1 parent 974be5d
commit 155cbc7
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 22 deletions.
diff --git a/...ic/android/app/src/main/java/com/airbnb/android/lottie/rnexamplefabric/MainApplication.kt b/...ic/android/app/src/main/java/com/airbnb/android/lottie/rnexamplefabric/MainApplication.kt
@@ -38,7 +38,7 @@ class MainApplication : Application(), ReactApplication {
         SoLoader.init(this, false)
         if (BuildConfig.IS_NEW_ARCHITECTURE_ENABLED) {
             // If you opted-in for the New Architecture, we load the native entry point for this app.
-            load(bridgelessEnabled = true)
+            load()
         }
         ReactNativeFlipper.initializeFlipper(this, reactNativeHost.reactInstanceManager)
     }

diff --git a/apps/fabric/ios/example.xcodeproj/project.pbxproj b/apps/fabric/ios/example.xcodeproj/project.pbxproj
@@ -923,11 +923,7 @@
 					"-DFOLLY_CFG_NO_COROUTINES=1",
 					"-DRN_FABRIC_ENABLED",
 				);
-				OTHER_LDFLAGS = (
-					"$(inherited)",
-					"-Wl",
-					"-ld_classic",
-				);
+				OTHER_LDFLAGS = "$(inherited)";
 				REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
 				SDKROOT = iphoneos;
 				USE_HERMES = true;
@@ -1003,11 +999,7 @@
 					"-DFOLLY_CFG_NO_COROUTINES=1",
 					"-DRN_FABRIC_ENABLED",
 				);
-				OTHER_LDFLAGS = (
-					"$(inherited)",
-					"-Wl",
-					"-ld_classic",
-				);
+				OTHER_LDFLAGS = "$(inherited)";
 				REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
 				SDKROOT = iphoneos;
 				USE_HERMES = true;

diff --git a/apps/fabric/ios/example/AppDelegate.mm b/apps/fabric/ios/example/AppDelegate.mm
@@ -19,11 +19,6 @@ - (NSURL *)sourceURLForBridge:(RCTBridge *)bridge
   return [self getBundleURL];
 }
 
-- (BOOL)bridgelessEnabled
-{
-    return YES;
-}
-
 - (NSURL *)getBundleURL
 {
 #if DEBUG

diff --git a/packages/core/src/specs/LottieAnimationViewNativeComponent.ts b/packages/core/src/specs/LottieAnimationViewNativeComponent.ts
@@ -55,16 +55,13 @@ export interface NativeProps extends ViewProps {
   textFiltersAndroid?: ReadonlyArray<TextFilterAndroidStruct>;
   textFiltersIOS?: ReadonlyArray<TextFilterIOSStruct>;
   onAnimationFinish?: BubblingEventHandler<
-    OnAnimationFinishEvent,
-    'onAnimationFinish'
+    OnAnimationFinishEvent
   >;
   onAnimationFailure?: BubblingEventHandler<
-    AnimationFailureEvent,
-    'onAnimationFailure'
+    AnimationFailureEvent
   >;
   onAnimationLoaded?: BubblingEventHandler<
-    AnimationLoadedEvent,
-    'onAnimationLoaded'
+    AnimationLoadedEvent
   >;
 }