New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade examples to 0.71.0 #962
Conversation
@AlexanderEggers Can you check the Android paper example here and see if you can build it? |
Sure I will have a look this weekend 👍 |
@matinzd I had a look at the changes + did a few local changes that I can push up if you want? I am actually unable to build the paper apps using the RN 0.71 upgrade. It seems to be related to certain sub-dependencies not supporting RN 0.71 yet which throws error like the following for me:
We could try to patch these sub-dependencies but I am not certain if that is the suggested way by the RN team. cc @emilioicai |
@AlexanderEggers I had the same issue. I think we can fix it by overriding sub dependecies with gradle on top or for now you can just patch them and then we can come up with a better solution. |
Ok, I will take care of patching then 👍 Should I raise a separate PR for that work or do I have the right repo permissions to push directly into this branch? It is probably worth raising this with RN if that wasn't discussed somewhere before. |
You can make a PR off of this branch. |
1348fc5
to
cf5aa96
Compare
@matinzd I tried patching these libs but no luck to resolve all errors. For some reasons the react plugin is not properly resolved. |
I will also take a look into that when I find a free time. Thank you! @AlexanderEggers |
@AlexanderEggers I figured out that cc: @emilioicai |
@matinzd Should we remove react-native-windows from the paper-example project then? |
I don't know. I was thinking maybe dropping support for windows for now if possible. But @emilioicai should comment on that. |
iOS and Android support are more important now. We could re-add the support as a separate initiative and recommend the current version which seems to be working fine for current windows users. |
BREAKING CHANGE: remove react-native-windows support on paper due to microsoft/react-native-windows#1109
Upgrade all examples to
0.71.0
to prepare for rolling out new architecture.