Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade examples to 0.71.0 #962

Merged
merged 3 commits into from Jan 17, 2023
Merged

chore: upgrade examples to 0.71.0 #962

merged 3 commits into from Jan 17, 2023

Conversation

matinzd
Copy link
Collaborator

@matinzd matinzd commented Jan 11, 2023

Upgrade all examples to 0.71.0 to prepare for rolling out new architecture.

@matinzd matinzd changed the title chore: upgrade fabric example to 0.71.0-rc.5 chore: upgrade examples to 0.71.0-rc.5 Jan 11, 2023
@matinzd matinzd changed the title chore: upgrade examples to 0.71.0-rc.5 chore: upgrade examples to 0.71.0 rc Jan 11, 2023
@matinzd matinzd marked this pull request as draft January 12, 2023 18:01
@matinzd matinzd changed the title chore: upgrade examples to 0.71.0 rc chore: upgrade examples to 0.71.0 Jan 12, 2023
yarn.lock Show resolved Hide resolved
@matinzd
Copy link
Collaborator Author

matinzd commented Jan 13, 2023

@AlexanderEggers Can you check the Android paper example here and see if you can build it?

@AlexanderEggers
Copy link
Contributor

Sure I will have a look this weekend 👍

@AlexanderEggers
Copy link
Contributor

@matinzd I had a look at the changes + did a few local changes that I can push up if you want? I am actually unable to build the paper apps using the RN 0.71 upgrade. It seems to be related to certain sub-dependencies not supporting RN 0.71 yet which throws error like the following for me:

* What went wrong:
Could not determine the dependencies of task ':app:compileDebugJavaWithJavac'.
> Could not resolve all task dependencies for configuration ':app:debugCompileClasspath'.
   > Could not find com.facebook.react:react-android:.
     Required by:
         project :app
   > Could not find com.facebook.react:hermes-android:.
     Required by:
         project :app
   > Could not find any matches for com.facebook.react:react-native:+ as no versions of com.facebook.react:react-native are available.
     Required by:
         project :app > project :react-native-community_slider
         project :app > project :react-native-picker_picker

We could try to patch these sub-dependencies but I am not certain if that is the suggested way by the RN team.

cc @emilioicai

@matinzd
Copy link
Collaborator Author

matinzd commented Jan 14, 2023

@AlexanderEggers I had the same issue. I think we can fix it by overriding sub dependecies with gradle on top or for now you can just patch them and then we can come up with a better solution.

@AlexanderEggers
Copy link
Contributor

Ok, I will take care of patching then 👍 Should I raise a separate PR for that work or do I have the right repo permissions to push directly into this branch?

It is probably worth raising this with RN if that wasn't discussed somewhere before.

@matinzd
Copy link
Collaborator Author

matinzd commented Jan 14, 2023

Ok, I will take care of patching then 👍 Should I raise a separate PR for that work or do I have the right repo permissions to push directly into this branch?

It is probably worth raising this with RN if that wasn't discussed somewhere before.

You can make a PR off of this branch.
Yes, I think it can be related to reactwg/react-native-new-architecture#105.

@AlexanderEggers
Copy link
Contributor

@matinzd I tried patching these libs but no luck to resolve all errors. For some reasons the react plugin is not properly resolved.

@matinzd
Copy link
Collaborator Author

matinzd commented Jan 15, 2023

I will also take a look into that when I find a free time. Thank you! @AlexanderEggers

@matinzd
Copy link
Collaborator Author

matinzd commented Jan 16, 2023

@AlexanderEggers I figured out that react-native-windows is causing conflicts.
I submitted an issue here.

cc: @emilioicai

@matinzd matinzd marked this pull request as ready for review January 16, 2023 15:57
@AlexanderEggers
Copy link
Contributor

@matinzd Should we remove react-native-windows from the paper-example project then?

@matinzd
Copy link
Collaborator Author

matinzd commented Jan 16, 2023

@matinzd Should we remove react-native-windows from the paper-example project then?

I don't know. I was thinking maybe dropping support for windows for now if possible. But @emilioicai should comment on that.
But unfortunately we are using it and we are supporting windows.

@emilioicai
Copy link
Member

iOS and Android support are more important now. We could re-add the support as a separate initiative and recommend the current version which seems to be working fine for current windows users.

BREAKING CHANGE: remove react-native-windows support on paper due to microsoft/react-native-windows#1109
@matinzd matinzd merged commit 00ea361 into master Jan 17, 2023
@matinzd matinzd deleted the chore/upgrade_examples branch January 17, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants