Rename Configuration#modules to #prepare [WIP] #58
Conversation
runlevel5
force-pushed
the
issue-57
branch
3 times, most recently
from
79d1b39
to
47f6030
Compare
runlevel5
changed the title
|
Changes Unknown when pulling 58af8e3 on joneslee85:issue-57 into * on lotus:master*. |
| @@ -507,6 +503,16 @@ def duplicate | |||
| end | |||
| end | |||
|
|
|||
| # Return included modules | |||
| # | |||
| # @return [Array<Proc>] array of included modules | |||
There was a problem hiding this comment.
not only return the included modules, also the before block and use Something, isn't it?
There was a problem hiding this comment.
yeah, I think I will reword it to array of included blocks, how does it sound?
|
Changes Unknown when pulling 79d1b39 on joneslee85:issue-57 into * on lotus:master*. |
|
Changes Unknown when pulling 47f6030 on joneslee85:issue-57 into * on lotus:master*. |
|
Changes Unknown when pulling cce8806 on joneslee85:issue-57 into * on lotus:master*. |
|
Changes Unknown when pulling 617e36f on joneslee85:issue-57 into * on lotus:master*. |
| # @api private | ||
| # | ||
| # @see Lotus::Controller::Configuration#prepare | ||
| attr_reader :modules |
There was a problem hiding this comment.
attr_writer :modules at the bottom of the file can be removed
There was a problem hiding this comment.
@AlfonsoUceda no we cannot remove it, please see line 503: c.modules = modules.dup
Closes #57