Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various tidying #7

Merged
merged 5 commits into from
Apr 11, 2014
Merged

Various tidying #7

merged 5 commits into from
Apr 11, 2014

Conversation

karlfreeman
Copy link

Can rebase into one commit if you like.

@karlfreeman
Copy link
Author

The content of .gitignore can be made better and more opinionated however the main thing is to get some consistency.

@jodosha
Copy link
Member

jodosha commented Apr 11, 2014

@karlfreeman Thanks but I can't merge yet because of the modifications of Gemfile.

I need local development to use local versions of the gems (aka use path). The reason why Utils exists is to enhance Ruby core/stdlib for all the other Lotus frameworks. I can't release a version of Utils each time that I need a small feature. For instance, now on Model I'm implementing types coercion, which is provided at low level by Utils HEAD.

In general I want people to use RubyGems to get the latest stable version of a Lotus framework.
If you clone from GH you want to contribute, so a development setup is required.

Can you please revert it?
Thanks

@karlfreeman
Copy link
Author

How about a compromise:

source 'https://rubygems.org'
gemspec

unless ENV['TRAVIS']
  gem 'byebug',      require: false, platforms: :ruby if RUBY_VERSION == '2.1.1'
  gem 'yard',        require: false
  gem 'lotus-utils', require: false, github: 'lotus/utils'
else
  gem 'lotus-utils'
end

gem 'haml',      require: false
gem 'simplecov', require: false
gem 'coveralls', require: false

Its important to reduce any friction between someone being able to quickly pull down a repo and create a test. I understand that utils will change often but I don't want to care about cloning down utils into a certain place to just change something in view. Locally you can do what you like 😄.

@jodosha
Copy link
Member

jodosha commented Apr 11, 2014

@karlfreeman 👍 Would you mind to amend accordingly? Thanks.

@karlfreeman
Copy link
Author

@jodosha will do.

@karlfreeman
Copy link
Author

@jodosha shall I rebase this and hanami/router#7 into one commit each or are you happy as is?

@karlfreeman
Copy link
Author

@jodosha Also I gave controller and 'coming soon' model a miss for now but happy to go through with similar changes.

jodosha added a commit that referenced this pull request Apr 11, 2014
@jodosha jodosha merged commit 04a5c54 into hanami:master Apr 11, 2014
@jodosha
Copy link
Member

jodosha commented Apr 11, 2014

@karlfreeman thank you.

@karlfreeman karlfreeman deleted the various-tidying branch April 11, 2014 15:39
timriley added a commit that referenced this pull request Mar 15, 2020
Make arguments to partial method calls available within their templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants