-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various tidying #7
Conversation
The content of |
@karlfreeman Thanks but I can't merge yet because of the modifications of I need local development to use local versions of the gems (aka use In general I want people to use RubyGems to get the latest stable version of a Lotus framework. Can you please revert it? |
How about a compromise: source 'https://rubygems.org'
gemspec
unless ENV['TRAVIS']
gem 'byebug', require: false, platforms: :ruby if RUBY_VERSION == '2.1.1'
gem 'yard', require: false
gem 'lotus-utils', require: false, github: 'lotus/utils'
else
gem 'lotus-utils'
end
gem 'haml', require: false
gem 'simplecov', require: false
gem 'coveralls', require: false Its important to reduce any friction between someone being able to quickly pull down a repo and create a test. I understand that |
@karlfreeman 👍 Would you mind to amend accordingly? Thanks. |
@jodosha will do. |
@jodosha shall I rebase this and hanami/router#7 into one commit each or are you happy as is? |
@jodosha Also I gave controller and 'coming soon' model a miss for now but happy to go through with similar changes. |
@karlfreeman thank you. |
Make arguments to partial method calls available within their templates
Can rebase into one commit if you like.