Skip to content

Commit

Permalink
Addresses some clang-tidy warnings against reference data members
Browse files Browse the repository at this point in the history
  • Loading branch information
louis-langholtz committed May 12, 2023
1 parent 977c2b6 commit 2db57cd
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
7 changes: 5 additions & 2 deletions PlayRho/Common/FlagGuard.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,11 @@ namespace playrho {
FlagGuard() = delete;

private:
T& m_flag; ///< Flag.
T m_value; ///< Value.
/// @brief Flag.
T& m_flag; // NOLINT(cppcoreguidelines-avoid-const-or-ref-data-members)

/// @brief Value.
T m_value;
};

} // namespace playrho
Expand Down
3 changes: 2 additions & 1 deletion PlayRho/Common/Templates.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,8 @@ using IsReverseIterable = typename detail::IsReverseIterableImpl<T>;
/// @see https://stackoverflow.com/a/28139075/7410358
template <typename T>
struct ReversionWrapper {
T& iterable; ///< Reference to underlying iterable.
/// @brief Reference to underlying iterable.
T& iterable; // NOLINT(cppcoreguidelines-avoid-const-or-ref-data-members)
};

/// @brief Begin function for getting a reversed order iterator.
Expand Down

0 comments on commit 2db57cd

Please sign in to comment.