New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Checks are run even when Inconsequential files are changed #55
Comments
Agreed. I'd looked into this before too.
AppVeyor has a web page on commits filtering. It says I think we'd both prefer a more automatic approach though that filtered based on pre-configured file names that are configured in the So not sure where to go with this for the moment except to add filtering for AppVeyor and just have to live with Travis-CI continuing for now. |
@louis-langholtz Alright, that makes sense. I didn't notice those tags before. I'll use them for docs changes from now on. I'll leave it up to you whether to close this issue or not. |
I like this issue and want to keep it open. I'll update the AppVeyor config file to filter some file changes out for now and then keep this open till I do the same for Travis-CI (after Travis-CI makes something like this available). |
Also note that doc changes may still have need or want of being CI managed like for building/updating the |
I'm thinking that Travis-CI runs for more branches than it needs to. Perhaps |
Closing this now. If/when Travis-CI updates its filtering capacity this should get revisited again. |
[skip ci] ...because of [issue with AppVeyor build checks](louis-langholtz/PlayRho#55).
Expected/Desired Behavior or Experience:
The build system skips prs where no source code files were modified.
Actual Behavior:
I just noticed when I submitted pr #54 that the system is running the build tests (and I assume it's going to run coveralls and the benchmark tests afterward). The only change I made was to a documentation (.md) file. I know the consequences for us (the maintainers) are minimal, but this seems like a poor use of public resources.
Steps to Reproduce the Actual Behavior:
Submit a pr with only documentation changes.
The text was updated successfully, but these errors were encountered: