Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Checks are run even when Inconsequential files are changed #55

Closed
NauticalMile64 opened this issue Aug 29, 2017 · 6 comments
Closed
Assignees
Labels
Enhancement For suggestions or changes that enhance any part of the project and isn't a bug.

Comments

@NauticalMile64
Copy link
Contributor

Expected/Desired Behavior or Experience:

The build system skips prs where no source code files were modified.

Actual Behavior:

I just noticed when I submitted pr #54 that the system is running the build tests (and I assume it's going to run coveralls and the benchmark tests afterward). The only change I made was to a documentation (.md) file. I know the consequences for us (the maintainers) are minimal, but this seems like a poor use of public resources.

Steps to Reproduce the Actual Behavior:

Submit a pr with only documentation changes.

@louis-langholtz louis-langholtz added the Enhancement For suggestions or changes that enhance any part of the project and isn't a bug. label Aug 29, 2017
@louis-langholtz
Copy link
Owner

Agreed. I'd looked into this before too.

[skip ci] or [ci skip] can manually be used within git commit messages to skip CI building (for both CI systems).

AppVeyor has a web page on commits filtering. It says [skip appveyor] in the commit message will skip AppVeyor builds.

I think we'd both prefer a more automatic approach though that filtered based on pre-configured file names that are configured in the appveyor.yml file. AppVeyor has that capability (see previous link). Unfortunately, Travis-CI doesn't currently seem to have support for this (see Exclude files from triggering a build).

So not sure where to go with this for the moment except to add filtering for AppVeyor and just have to live with Travis-CI continuing for now.

@louis-langholtz louis-langholtz self-assigned this Aug 29, 2017
@NauticalMile64
Copy link
Contributor Author

NauticalMile64 commented Aug 29, 2017

@louis-langholtz Alright, that makes sense. I didn't notice those tags before. I'll use them for docs changes from now on. I'll leave it up to you whether to close this issue or not.

@louis-langholtz
Copy link
Owner

I like this issue and want to keep it open. I'll update the AppVeyor config file to filter some file changes out for now and then keep this open till I do the same for Travis-CI (after Travis-CI makes something like this available).

@louis-langholtz
Copy link
Owner

Also note that doc changes may still have need or want of being CI managed like for building/updating the gh-pages branch after every PR. Just something else I need to keep in mind about this issue.

@louis-langholtz
Copy link
Owner

I'm thinking that Travis-CI runs for more branches than it needs to. Perhaps .travis.yml file needs to be updated to un-comment the branches: only: info.

louis-langholtz added a commit that referenced this issue Aug 31, 2017
Change to only run Travis-CI for updates to the master branch.
@louis-langholtz
Copy link
Owner

Closing this now. If/when Travis-CI updates its filtering capacity this should get revisited again.

robinsedlaczek added a commit to robinsedlaczek/ForceFeedbackProgramming that referenced this issue Apr 7, 2019
[skip ci]

...because of [issue with AppVeyor build checks](louis-langholtz/PlayRho#55).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For suggestions or changes that enhance any part of the project and isn't a bug.
Projects
None yet
Development

No branches or pull requests

2 participants