Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves non d2 code up to playrho #420

Merged
merged 20 commits into from
Jul 21, 2021
Merged

Moves non d2 code up to playrho #420

merged 20 commits into from
Jul 21, 2021

Conversation

louis-langholtz
Copy link
Owner

Description - What's this PR do?

Moves code that existed in the playrho::d2 namespace that didn't have to be under d2 up to the playrho namespace. Also does some renaming and adds a slight bit more unit test code coverage.

Impacts/Risks of These Changes?

Unusual user code that directly uses these particular pieces of code may need to be updated to use this latest code.

@louis-langholtz louis-langholtz added Enhancement For suggestions or changes that enhance any part of the project and isn't a bug. Docs Use when issue or pull request relates to the documentation of the project. Library For issues that effect the library and aren't specific to any particular application. labels Jul 21, 2021
@louis-langholtz louis-langholtz added this to the 2.0 Release milestone Jul 21, 2021
@louis-langholtz louis-langholtz self-assigned this Jul 21, 2021
@louis-langholtz louis-langholtz added this to To Do in 100% Unit Test Coverage via automation Jul 21, 2021
@louis-langholtz louis-langholtz added this to To Do in Documentation work via automation Jul 21, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 98.801% when pulling 264ad27 on move-non-d2-up into 5482d88 on master.

@louis-langholtz louis-langholtz merged commit 6ce205c into master Jul 21, 2021
Documentation work automation moved this from To Do to Done Jul 21, 2021
100% Unit Test Coverage automation moved this from To Do to Done Jul 21, 2021
@louis-langholtz louis-langholtz deleted the move-non-d2-up branch July 21, 2021 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Use when issue or pull request relates to the documentation of the project. Enhancement For suggestions or changes that enhance any part of the project and isn't a bug. Library For issues that effect the library and aren't specific to any particular application.
Projects
3-D Support
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants