-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves non d2 code up to playrho #420
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be more consistent with the naming of ToiConf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Docs
Use when issue or pull request relates to the documentation of the project.
Enhancement
For suggestions or changes that enhance any part of the project and isn't a bug.
Library
For issues that effect the library and aren't specific to any particular application.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description - What's this PR do?
Moves code that existed in the
playrho::d2
namespace that didn't have to be underd2
up to theplayrho
namespace. Also does some renaming and adds a slight bit more unit test code coverage.Impacts/Risks of These Changes?
Unusual user code that directly uses these particular pieces of code may need to be updated to use this latest code.