Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates 20231218 #552

Merged
merged 7 commits into from
Dec 19, 2023
Merged

Updates 20231218 #552

merged 7 commits into from
Dec 19, 2023

Conversation

louis-langholtz
Copy link
Owner

Description - What's this PR do?

Makes some clang-tidy suggested changes and addresses issue #549 .

Impacts/Risks of These Changes?

Code written to directly use BodyConf member variables like location and angle will need to be updated to set these via BodyConf::UseLocation and BodyConf::UseAngle or to get these using GetLocation(const BodyConf&) and GetAngle(const BodyConf&).

Related Issues

Issue #549.

- Adds GetFlags member function to Body to provide read access to the
  body's flag state.
- Uses GetFlags instead of GetType in operator==.
- Updates unit test code to ensure flags state is part of the equality
  operator implementation.

This resolves issue #548.
- Copies logic of GetFlags using Body accessor member functions into
  their non-member equivalents.
- Removes GetFlags() using Body accessor member functions.
@louis-langholtz louis-langholtz added Enhancement For suggestions or changes that enhance any part of the project and isn't a bug. Library For issues that effect the library and aren't specific to any particular application. labels Dec 19, 2023
@louis-langholtz louis-langholtz added this to the 2.0 Release milestone Dec 19, 2023
@louis-langholtz louis-langholtz self-assigned this Dec 19, 2023
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@coveralls
Copy link

Coverage Status

coverage: 99.293% (+0.001%) from 99.292%
when pulling 57867fa on updates-20231218
into b09895e on master.

@louis-langholtz louis-langholtz merged commit 4a36677 into master Dec 19, 2023
19 checks passed
@louis-langholtz louis-langholtz deleted the updates-20231218 branch December 19, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For suggestions or changes that enhance any part of the project and isn't a bug. Library For issues that effect the library and aren't specific to any particular application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants