Updates 20231222 #558
Merged
Updates 20231222 #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renames Contact::UnsetIsSensor to Contact::UnsetSensor. - Adds OutOfRange derived class of std::out_of_range to help identify what was out-of-range. - Updates AabbTreeWorld code to use new OutOfRange as nested exception for std::out_of_range exceptions. - Adds unit test code to more closely check SetContact(AabbTreeWorld&, ContactID, Contact) behavior.
louis-langholtz
added
Enhancement
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description - What's this PR do?
BodyConf::UseType& replaces uses withBodyConf::Use.Contactinterfaces.SetContact(AabbTreeWorld&,...)to be more restrictive about what it allows.OutOfRangederived class ofstd::out_of_rangeto help with diagnostics.This work was in part motivated for my getting a better handle on how to properly/fully support serialization/deserialization per #544 .