-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake fix in install rules #487
Comments
@Zbyl Thank you for your interest in PlayRho and for filing this issue! Looking at the latest CMake Installing Targets help, I see the following usage specification:
Reading this now and the issue you had linked, I'm recognizing how having the line
after the
line (found in the I imagine this risk depends though on just how order dependent CMake is, and how greedily CMake evaluates arguments like
Are you actually running into a problem with this, or just reporting this riskiness? I ask in part because none of my manual testing had detected this being a problem. CMake seems too fragile to me however and the usage specification suggests it could be a problem. I'd like to see the parse tree CMake builds out of this |
See also response by Craig Scott at https://gitlab.kitware.com/cmake/cmake/-/issues/20636 asserting that having COMPONENT after INCLUDES DESTINATION is "malformed".
See also response by Craig Scott at https://gitlab.kitware.com/cmake/cmake/-/issues/20636 asserting that having COMPONENT after INCLUDES DESTINATION is "malformed".
Need to also back port changes from #488 into release-1.1. |
Hi. My Vcpkg "port" looks like this (I've took one for box2d as an example to create it) vcpkg.json
portfile.cmake
|
See also response by Craig Scott at https://gitlab.kitware.com/cmake/cmake/-/issues/20636 asserting that having COMPONENT after INCLUDES DESTINATION is "malformed". (cherry picked from commit 6c207ae)
v1.1.2 has been released now with the change in it to address this. Hopefully it fixes this problem and doesn't introduce any new ones. Please let me know what your experience with it is. Thanks again. |
Gonna assume this is fixed now. |
CMake has a bug:
COMPONENT Library
must be the second line. When it is the last one, both words are interpreted as include directories!(See similar issue here: https://gitlab.kitware.com/cmake/cmake/-/issues/20636)
The text was updated successfully, but these errors were encountered: