Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to "official" fork #682

Open
RollingHog opened this issue Jul 31, 2021 · 8 comments
Open

Add link to "official" fork #682

RollingHog opened this issue Jul 31, 2021 · 8 comments

Comments

@RollingHog
Copy link

RollingHog commented Jul 31, 2021

Since this won't be supported anymore, maybe owner should add a link to what would be recognized as a "official" and stable fork of this repo, like https://github.com/seald/nedb/ ?

@RollingHog
Copy link
Author

RollingHog commented Jul 31, 2021

Another good link to be added is https://github.com/bajankristof/nedb-promises#readme , since callbacks are you know, a little uncomfortable.

@chmac
Copy link

chmac commented Aug 9, 2021

This might also be worth considering: https://github.com/nedbhq/nedb-core

Courtesy of https://andremiras.github.io/gitpop3/

@chmac
Copy link

chmac commented Aug 9, 2021

Also perhaps https://github.com/typicode/lowdb deserves a mention as a solid alternative

@tex0l
Copy link

tex0l commented May 13, 2022

@RollingHog We released a version of our fork which removes the use of async in favor of a Promise-based executor, and which exposes a Promise-based interface:

https://github.com/seald/nedb/blob/master/CHANGELOG.md#300---2022-03-16

@amirouche
Copy link

amirouche commented May 15, 2022

a Promise-based executor

@tex0l why did you choose the promise-based executor?

@tex0l
Copy link

tex0l commented May 15, 2022

a Promise-based executor

@tex0l why did you choose the promise-based executor?

Because doing it without async but with the built-in ES6 Promise makes it dependency-free.

@amirouche
Copy link

amirouche commented May 16, 2022

With Chez and Gambit callback-based code is ten times faster, than colored async code.

@tex0l
Copy link

tex0l commented May 18, 2022

At Seald (for which we maintain this fork), we don't observe any performance issue with our implementation. If you want to do a benchmark between the historical version of nedb & our latest version with async code, feel free. I don't think there is a 10x difference.

Even if there is on some environments, as the whole JS ecosystem moves towards async code, I don't think going back to callbacks is a good idea. The subsequent versions of node.js & browsers will catch up the difference if there's any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants