Close Database #414
Open
Close Database #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns and stops subsequent operations from being performed on the Database after its closed.
Database close
Fixed typo and tests
…her open & close tests.
Added callback handling in closeData for inMemoryOnly databases. Fur…
This was referenced Aug 10, 2017
|
Hello @louischatriot any new about this PR ? Will it be merged ? I need this "close" function too. Thanks |
|
Can you not fork this branch and use it? I guess that no development in two years means that @louischatriot is not able to continue with this project. We had this fork working perfectly well in a number of deployments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some soak testing we were doing we found that we needed to close the NeDB.
So here is our implementation of the close functionality.
On calling it stops any further commands from being accepted, processes the command queue and finally executes the close.