Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some new languages de/ab/ru/pl/sq/jp/hi #90

Closed
wants to merge 18 commits into from

Conversation

operationairstrike
Copy link

@operationairstrike operationairstrike commented Nov 20, 2023

Added German language.

@operationairstrike
Copy link
Author

Added Arabic language.

@operationairstrike
Copy link
Author

Added russian

@operationairstrike operationairstrike changed the title Create de.json Added some new languages de/ab/ru Nov 20, 2023
@operationairstrike operationairstrike changed the title Added some new languages de/ab/ru Added some new languages de/ab/ru/pl Nov 20, 2023
@operationairstrike
Copy link
Author

ready to merge

@operationairstrike operationairstrike changed the title Added some new languages de/ab/ru/pl Added some new languages de/ab/ru/pl/sq/jp/hi Nov 20, 2023
@louislam
Copy link
Owner

Thanks, but were they translated by a tool or human?

@Zaid-maker
Copy link
Contributor

Thanks, but were they translated by a tool or human?

Looks like done by a tool, because it took time to translate by Human.

@louislam louislam added the question Further information is requested label Nov 20, 2023
@louislam
Copy link
Owner

louislam commented Nov 20, 2023

  1. Please breakdown the languages into other pull requests, so native people could help to review.
  2. Must follows ISO language codes, otherwise browser cannot match it.

@operationairstrike
Copy link
Author

operationairstrike commented Nov 20, 2023

It's machine translated.

@Zaid-maker
Copy link
Contributor

i think u mis-understood what he meant.

@operationairstrike
Copy link
Author

Tell me what he meant then

1 similar comment
@operationairstrike
Copy link
Author

Tell me what he meant then

@operationairstrike
Copy link
Author

operationairstrike commented Nov 20, 2023

I think i can't create a new pull request if my last one isn't completed yet.

@Zaid-maker
Copy link
Contributor

Zaid-maker commented Nov 20, 2023

Tell me what he meant then

Please breakdown the languages into other pull requests, so native people could help to review.

He says make a new PR's for every new Language Translation you are doing, instead of creating all in one PR so the People speaking native language can review!

@operationairstrike
Copy link
Author

Tell me what he meant then

Please breakdown the languages into other pull requests, so native people could help to review.

He says make a new PR's for every new Language Translation you are doing, instead of creating all in one PR so the People speaking native language can review!

Ik but the thing is it's a lot of work to delete all of it and make a new one the thing is that takes a lot of time like why can't people just use one all languages are in the title.

@operationairstrike
Copy link
Author

Why does it need multiple pull request if the translation is completed?

@furkanipek
Copy link
Contributor

Copy your translation files to a different directory.
After copying, paste the individual files between the language files in the dockge. After creating a new PR, repeat this process for a different language.

This will make the process easier.

@Zaid-maker
Copy link
Contributor

Zaid-maker commented Nov 21, 2023

Ik but the thing is it's a lot of work to delete all of it and make a new one the thing is that takes a lot of time like why can't people just use one all languages are in the title.

As u know we have a tool in Uptime Kuma which open a single Translation PR and people speaking native language can review on the Web, but in this project Louis said he don't have time to setup the tool right now. Maybe in future he will. But right know we are required to open one Pull Request for single language translation everyone is following that same manner and u are required aswell, Hope that's help 👍

Speaking of your work u did a great work! But you can do this if it's suits u, create branches in your fork and make translation in those branches and when u done Open a Proper Pull Request for every language u translated and Louis will review and merge it.

Copy link
Contributor

@Aonodensetsu Aonodensetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

native (edit: polish) speaker reporting for duty :)

@@ -0,0 +1,94 @@
{
"languageName": "Polish",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"languageName": "Polish",
"languageName": "Polski",

language names are typically in the language itself, to allow people bad at english a chance at finding them

"container": "Kontener | Kontenery",
"scanFolder": "Skanuj folder ze stosami",
"dockerImage": "Obraz",
"restartPolicyUnlessStopped": "Chyba że zatrzymano",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"restartPolicyUnlessStopped": "Chyba że zatrzymano",
"restartPolicyUnlessStopped": "Jeśli nie zatrzymano",

"in the case that it was not stopped" seems more accurate for the language

Suggested change
"restartPolicyUnlessStopped": "Chyba że zatrzymano",
"restartPolicyUnlessStopped": "Chyba, że zatrzymano",

alternatively, the gramatically correct version requires a comma before "że"

"restartPolicyUnlessStopped": "Chyba że zatrzymano",
"restartPolicyAlways": "Zawsze",
"restartPolicyOnFailure": "Przy awarii",
"restartPolicyNo": "Nie",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"restartPolicyNo": "Nie",
"restartPolicyNo": "Nie restartuj",

"no" isn't very descriptive, "don't restart" is a more appropriate message - even though it's a less direct translation

"restartPolicy": "Polityka restartu",
"containerName": "Nazwa kontenera",
"port": "Port | Porty",
"volume": "Wolumen | Wolumeny",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"volume": "Wolumen | Wolumeny",
"volume": "Wolumin | Woluminy",

disputed, but the most common spelling of the word uses the vowel "i"
edit: this only applies to the singular, the plural and all declinations are only correct with an "i"

"network": "Sieć | Sieci",
"dependsOn": "Zależność kontenera | Zależności kontenera",
"addListItem": "Dodaj {0}",
"deleteContainer": "Usuń",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"deleteContainer": "Usuń",
"deleteContainer": "Usuń kontener",

consistency with translations below

"Disable Auth": "Wyłącz autoryzację",
"I understand, please disable": "Rozumiem, proszę wyłączyć",
"Leave": "Opuść",
"Frontend Version": "Wersja frontu",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Frontend Version": "Wersja frontu",
"Frontend Version": "Wersja interfejsu graficznego",

reworded frontend to GUI, which is better than "front" (which would not be polish)

Suggested change
"Frontend Version": "Wersja frontu",
"Frontend Version": "Wersja frontend",

alternatively, use the actual english loanword instead of translating partially

"Leave": "Opuść",
"Frontend Version": "Wersja frontu",
"Check Update On GitHub": "Sprawdź aktualizacje na GitHub",
"Show update if available": "Pokaż aktualizację, jeśli dostępna",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Show update if available": "Pokaż aktualizację, jeśli dostępna",
"Show update if available": "Pokaż aktualizacje, jeśli dostępne",

plural for consistency

"Frontend Version": "Wersja frontu",
"Check Update On GitHub": "Sprawdź aktualizacje na GitHub",
"Show update if available": "Pokaż aktualizację, jeśli dostępna",
"Also check beta release": "Sprawdź także wydanie beta",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Also check beta release": "Sprawdź także wydanie beta",
"Also check beta release": "Sprawdź także wersje beta",

version is a more suitable word for the language (+plural for consistency)

"Logout": "Wyloguj się",
"Lowercase only": "Tylko małe litery",
"Convert to Compose": "Przekształć na Compose",
"Docker Run": "Uruchomienie Docker",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Docker Run": "Uruchomienie Docker",
"Docker Run": "Uruchom za pomocą Dockera",

"run with the use of Docker" instead of "turn on docker (as in docker itself, not a container on it)"

"Convert to Compose": "Przekształć na Compose",
"Docker Run": "Uruchomienie Docker",
"active": "aktywny",
"exited": "zakończony",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"exited": "zakończony",
"exited": "wyłączony",

"turned off" instead of "ended"

@louislam
Copy link
Owner

@Aonodensetsu Would you mind to create a new pull request?

This pull is going to be closed, it is really hard to be merged.

@louislam louislam closed this Nov 21, 2023
louislam added a commit that referenced this pull request Nov 21, 2023
* Create pl-PL.json

from #90 with merged review

* Update pl-PL.json

missed a few and noticed a few things that could be changed

* Add to list

* No overflow text

---------

Co-authored-by: Louis Lam <louislam@users.noreply.github.com>
@louislam louislam mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants