Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Webhook different on up and down cases #4203

Closed
clement-igonet opened this issue Dec 10, 2023 · 1 comment
Closed

Notification Webhook different on up and down cases #4203

clement-igonet opened this issue Dec 10, 2023 · 1 comment
Labels
area:notifications Everything related to notifications feature-request Request for new features to be added

Comments

@clement-igonet
Copy link

clement-igonet commented Dec 10, 2023

⚠️ Please verify that this feature request has NOT been suggested before.

Already covered in other notification types, but not for webhook type:

🏷️ Feature Request Type

New Notification

🔖 Feature description

When triggering a notification by webhook, I'd like the ability to send different POST request on up case and down case.

For instance:

  • up case: Request https://my_alerting_app/webhook/1/issues with {"issue_key":"NOTIF-1234"} BODY
  • down case: Request https://my_alerting_app/webhook/1/issues/NOTIF-1234/close with empty BODY

How may I set it up ?

✔️ Solution

Ability to select if the defined webhook is just for up case, down case, or the both.

❓ Alternatives

Create a dedicated notification specific for DevLake application.

Specs to generate a downtime INCIDENT by webhook: https://devlake.apache.org/docs/v0.20/Plugins/webhook

📝 Additional Context

@clement-igonet clement-igonet added the feature-request Request for new features to be added label Dec 10, 2023
@clement-igonet clement-igonet changed the title Notification Webhook on up and down Notification Webhook different on up and down cases Dec 10, 2023
@CommanderStorm CommanderStorm added the area:notifications Everything related to notifications label Dec 10, 2023
@CommanderStorm
Copy link
Collaborator

I don't see why this is not a duplicate of #508.
As far as I understand said issue, this covers all notification types.
=> closing as a duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications feature-request Request for new features to be added
Projects
None yet
Development

No branches or pull requests

2 participants