Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cookie check / monitor #4448

Closed
kamuffe opened this issue Feb 2, 2024 · 1 comment
Closed

Add Cookie check / monitor #4448

kamuffe opened this issue Feb 2, 2024 · 1 comment
Labels
area:monitor Everything related to monitors feature-request Request for new features to be added type:new proposing to add a new monitor

Comments

@kamuffe
Copy link

kamuffe commented Feb 2, 2024

πŸ“‘ I have found these related issues/pull requests

Nothing found

🏷️ Feature Request Type

New monitor, Change to existing monitor

πŸ”– Feature description

It would be nice if we could add a check to verify that a certain cookie is configured the right way. e.g. add checks for a "SID" cookie that the secure flag is set to true or httpOnly is also set to true.
Background:
Due to a framework update we lost these configurations and suddenly the flags were wrong at the cookies. So it would be nice if in such a case Uptime Kuma would alert us. It's also similar to the feature "Monotor SSL Cetificates" wich is already available.

βœ”οΈ Solution

It is possible to add one or more cookie checks with a configurable cookie name and add 1 or more properties per cookie which are checked.

❓ Alternatives

Nothing found.

πŸ“ Additional Context

No response

@kamuffe kamuffe added the feature-request Request for new features to be added label Feb 2, 2024
@CommanderStorm CommanderStorm added area:monitor Everything related to monitors type:new proposing to add a new monitor labels Feb 2, 2024
@CommanderStorm
Copy link
Collaborator

Monitoring cookies is covered in #3568 and I don't see an immediate difference in capability.
=> closing as a duplicate

In parallel, we are converting the json-query and keyword monitors into generic pieces.
This will make implementing something like #3568 a lot easier.
You can subscribe to/read these issues for further context/intel:

We can reopen if you make a good argument why this cannot be covered by a header-query monitor.

@CommanderStorm CommanderStorm closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:monitor Everything related to monitors feature-request Request for new features to be added type:new proposing to add a new monitor
Projects
None yet
Development

No branches or pull requests

2 participants