Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Binary body encoding via allowing a File Upload #4721

Open
2 tasks done
ltx0633 opened this issue Apr 28, 2024 · 7 comments
Open
2 tasks done

Support Binary body encoding via allowing a File Upload #4721

ltx0633 opened this issue Apr 28, 2024 · 7 comments
Labels
area:monitor Everything related to monitors feature-request Request for new features to be added type:enhance-existing feature wants to enhance existing monitor

Comments

@ltx0633
Copy link

ltx0633 commented Apr 28, 2024

⚠️ Please verify that this question has NOT been raised before.

  • I checked and didn't find similar issue

🛡️ Security Policy

📝 Describe your problem

I have an interface where the post content submitted is binary, but kuma just doesn't support it

📝 Error Message(s) or Log

No response

🐻 Uptime-Kuma Version

latest

💻 Operating System and Arch

centos

🌐 Browser

any

🖥️ Deployment Environment

  • Runtime: k8s
  • Database: sqlite
  • Filesystem used to store the database on: nfs
  • number of monitors: 10
@ltx0633 ltx0633 added the help label Apr 28, 2024
@chakflying
Copy link
Collaborator

What UI do you think would be suitable for inputting a binary body for your request?

@ltx0633
Copy link
Author

ltx0633 commented Apr 28, 2024

What UI do you think would be suitable for inputting a binary body for your request?

image

I use the following command to detect the service
curl -XPOST https://${my_services} --data-binary '@install.bin'

@CommanderStorm CommanderStorm added area:monitor Everything related to monitors type:enhance-existing feature wants to enhance existing monitor feature-request Request for new features to be added and removed help labels Apr 28, 2024
@CommanderStorm
Copy link
Collaborator

What Nelson was probing for is not how you are currently doing this, but rater how this should work.
I think another Body Encoding => file upload field might be the best solution.
image

@CommanderStorm
Copy link
Collaborator

On another note:

Filesystem used to store the database on: nfs

Please see the warnings in our wiki/readme:

Warning

Filesystem support for POSIX file locks is required to avoid SQLite database corruption. Be aware of possible file locking problems such as those commonly encountered with NFS. Please map the /app/data-folder to a local directory or volume.

@ltx0633
Copy link
Author

ltx0633 commented May 6, 2024

Will this make any progress?

@CommanderStorm
Copy link
Collaborator

What do you mean? Your feature-request is not even a week old..
=> not having much progress on an issue in this timeframe is normal.

I think you are a bit confused about how OpenSource works.
Software is delivered "as is" (no warranty, no guarantees). We are not a company so you are not paying for deliverables/timelines.

=> if you need an additional feature, you can:

  • developing it and contribute the change upstream (see our contribution guide).
  • Give the pull request a 👍🏻 to give others a better insight in what the rest of the community wants/needs
  • sponsor the project or write out a bounty on this PR..

@CommanderStorm
Copy link
Collaborator

In case you just wanted to unblock yourself:
Uptime Kuma does have the push-monitor. See https://github.com/louislam/uptime-kuma/tree/master/extra/push-examples for examples on how this can be used.

@CommanderStorm CommanderStorm changed the title Support post binary Support Binary body encoding May 6, 2024
@CommanderStorm CommanderStorm changed the title Support Binary body encoding Support Binary/File Upload body encoding May 6, 2024
@CommanderStorm CommanderStorm changed the title Support Binary/File Upload body encoding Support Binary body encoding via allowing a File Upload May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:monitor Everything related to monitors feature-request Request for new features to be added type:enhance-existing feature wants to enhance existing monitor
Projects
None yet
Development

No branches or pull requests

3 participants